From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48DA130DEB2; Thu, 21 May 2026 07:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779348050; cv=none; b=psOcr1caEeP9F+u9lXuG2zBbt9se7/+tjvXeVMgo5y+IC1iOR85FpwU9MAfUAWOPyGqJRUP1ZUbpp3rfKREqvzyq1vYW5lx9tngw0JDNEx6nICYgd+OBpiUBQ5LQMUHAXI800ie4z+iY3Ou/TLEhhr+xtaPcEeYL78/k9rS//5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779348050; c=relaxed/simple; bh=NJTuqVhhx4ZZxUfa0gsUnmbbhttyXCV5v2ViNtsMC80=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W/0O31nWYSM5a4qKumD2300L1egMvfeZKUQKD1R9UN3F0jfdYWz+7AFwl/W1Nyg0iolGURBmNezVeFPFXxfqAcL4qYxXbqGcKXwZOUVRkXsaNBgLiZBR+4J6yo0KeTz1IKRh5OZ/ISQ4GNyfU8iJpkSz0yBpYYinwSFr1QU2PFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GQ9+cjtw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GQ9+cjtw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2431A1F000E9; Thu, 21 May 2026 07:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779348049; bh=nI+G+aCuQ9siluJQySImBqqIqDQnteIx2vdEuLDlJvI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=GQ9+cjtws8KOBpcE6OwlZIUgpsEIZfC93Nr7AvRXM31Al+yg3J8s6DyWN9ZN2wvuI PRNs8IuC8nkFzYl51762dQ9DnCLECQDAeDFiOiKL4dqjACkM1WKMrpiYnxhMJmFd87 rZdb3coZQJY549hcgIEWdtwmdLyM0j1wrnSdlqmXIeX5f8bq0jp4s+lISqNMfs3QY4 scVM3cl+zxWqdLmclcYqBCYSiHRDBJ8c2FEkOzCw0o03myMOvpaC9GVaFHgVqRcSR1 wHeBaVDGz3Jv9aT5nid6N2qqsW+vsrW4kAbcSwLLipPJf11HhqnIy3TMemEolI128h 7CgCKlzBU1o0Q== Message-ID: <86f76a81-832d-4ba5-81d5-38b46b7dc0a7@kernel.org> Date: Thu, 21 May 2026 09:20:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property To: Kamal Wadhwa , jishnu.prakash@oss.qualcomm.com Cc: Rakesh Kota , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20260518-add_dc_in_support-v1-0-31fbaa329879@oss.qualcomm.com> <20260518-add_dc_in_support-v1-1-31fbaa329879@oss.qualcomm.com> <20260519082526.odmn5dqi2jftwnln@hu-kotarake-hyd.qualcomm.com> <20260519-first-wine-bulldog-a6a4c7@quoll> <20260521071341.q4efqssppvettaey@hu-kamalw-hyd.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260521071341.q4efqssppvettaey@hu-kamalw-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 21/05/2026 09:13, Kamal Wadhwa wrote: > On Tue, May 19, 2026 at 12:35:13PM +0200, Krzysztof Kozlowski wrote: >> On Tue, May 19, 2026 at 01:55:26PM +0530, Rakesh Kota wrote: >>> >>>> And isn't lack of monitored battery property enough to indicate that? >>> >>> Regarding monitored-battery — its absence alone isn't sufficient. The >>> BATT_ID line on debug boards is pulled to ~10kΩ, which is used during >>> development phase where some battery properties are still present. The >>> same ~10kΩ value is also used on some genuinely battery-less production >>> platforms where no battery properties exist, making auto-detection >>> unreliable. Hence the need for an explicit DT property to identify >>> hardware platforms where no battery populated. >> >> I don't understand this logic. So you claim you have debug boards which >> do not have battery, but define monitored-battery? Then these are wrong >> and fix them first. > > Actually our firmware treats the debug board as a "fake battery" rather then > a "no-battery" case. > > This is done to avoid triggering shutdown or trigger power/thermal related > mitigations to kick in from the HLOS (android) that is configured mainly for > battery-backed devices. > > Note that we can know if its a debug board, just by looking at the battery > ID resistance or the battery profile name in the power supply properties > for `qcom-battmgr-bat` in sysfs. > > However, the problem started with the boards that are battery-less and > unfortunetely used the same debug board batt ID resistance value, so from > the firmware side the batteryless board is also seen same as a board with > debug-board connected. > > Since firmware does not have a way to dynamically tell if it on a > debug-board powered device or a DCIN powered device, We are required to > add this new DT property. Neither debug-board powered device nor battery-less will have monitored-battery, thus again, why lack of that property cannot tell you what you need? And no, you are not required to add a new DT property. Every wrong property was also justified like that... Best regards, Krzysztof