From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BF3CA1000 for ; Tue, 5 Sep 2023 16:21:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349178AbjIEQVh (ORCPT ); Tue, 5 Sep 2023 12:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354808AbjIEOec (ORCPT ); Tue, 5 Sep 2023 10:34:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88DA6189; Tue, 5 Sep 2023 07:34:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B7E4601D4; Tue, 5 Sep 2023 14:34:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69E45C433C8; Tue, 5 Sep 2023 14:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693924468; bh=JKzU5c4fzZh7BqSu7lUu+UIbm/Xs4iJnRhgm0x1qGEw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fQ4Ilp76JURnoa3wZePrwy+N/8dSE58crRHBdJaIcF+vuMSt6WoE3alHqX6xFMbjq iWxt+b+ml6R9tXnOOyUgy6xH4prZDPci+HWVe9b4nU+kx0pQ9/IJ3aF0pNtIEnOie1 ecc81Yq6g4gK5jYGZp21jchXbPHqkIVnnLHVhWIgUvCN8gpkK4bqcomrG63BHM/EQU 3951VlNwvwuMZa2dyrqkbp/wJmfYEIuxj/rHtEy9Xxe+rn4/3pBRaiBmKCGFo6+1p+ LyteVD367Z4n4ftRanNPk/3ANx3YQZvypVIxb8IvZfhEhPZEUfBbj6+Bv/Q4UWNiO6 0CMysHAewrTng== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qdX8M-00AaTS-0t; Tue, 05 Sep 2023 15:34:26 +0100 Date: Tue, 05 Sep 2023 15:34:24 +0100 Message-ID: <86il8oeljj.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, Robin Murphy , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring , Fang Xiang Subject: Re: [PATCH 2/2] irqchip/gic-v3: Enable non-coherent redistributors/ITSes probing In-Reply-To: References: <20230905104721.52199-1-lpieralisi@kernel.org> <20230905104721.52199-3-lpieralisi@kernel.org> <86msy0etul.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, fangxiang3@xiaomi.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 05 Sep 2023 15:24:51 +0100, Lorenzo Pieralisi wrote: > > On Tue, Sep 05, 2023 at 12:34:58PM +0100, Marc Zyngier wrote: > > @@ -4808,6 +4812,11 @@ static const struct gic_quirk its_quirks[] = { > > .init = its_enable_rk3588001, > > }, > > #endif > > + { > > + .desc = "ITS: non-coherent attribute", > > + .property = "dma-noncoherent", > > + .init = its_set_non_coherent, > > + }, > > For the records, that requires adding a gic_enable_of_quirks() call for the > ITS DT node that at the moment is not needed, something like this: > > -- >8 -- > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 25a12b46ce35..3ae3cb9aadd9 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -4826,6 +4826,10 @@ static void its_enable_quirks(struct its_node *its) > u32 iidr = readl_relaxed(its->base + GITS_IIDR); > > gic_enable_quirks(iidr, its_quirks, its); > + > + if (is_of_node(its->fwnode_handle)) > + gic_enable_of_quirks(to_of_node(its->fwnode_handle), > + its_quirks, its); > } > Ah, well spotted. Yes, please fold this in. Thanks, M. -- Without deviation from the norm, progress is not possible.