From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E33BB146A79 for ; Fri, 27 Dec 2024 10:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735295232; cv=none; b=airR9rKRuMkKKOGjTlV2qnTTRZBA+bDdDVzMUty6Id+vYJ0keqaLP11gAIx8OGdNRwS7mz2MDgn89Bi1K5k3IJLNtecGdDVVW7M+JC09NM5sOqn1SMar6kp8b7vGb/15bW6M0zwND5Lq+7q88U3mmurhFvXHYs5lO5RwsiqdWSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735295232; c=relaxed/simple; bh=fU2sdWBrQB2PnLL4rIYUz4+FG6O6X/h4b2VgDw5HNtE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=TTgcPsoZkKaC0h8EPFyJunALvv0QWdKSt3ZX6QkR/m5oBsFiYPCoUCgh71scU4RvdMtv1FJNxL4D22GR9N0uzjiqfVb/hJxkhnXSzIhIyapB1p1e1s2tenUWltXgCP13tHFerMJgg/vffpQO7n5vQ/dGSzXNanXmTNcpmOfd3qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bcUiYQ56; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bcUiYQ56" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DA29C4CED0; Fri, 27 Dec 2024 10:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735295231; bh=fU2sdWBrQB2PnLL4rIYUz4+FG6O6X/h4b2VgDw5HNtE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bcUiYQ56MdZSoZMlhWBuVuNaDbzwzUd1XqHWEPGV4DuHkTbAs8uc/0wF4uOYFkG73 Bj9K/yyoR9BfvJTY+A/oMHvNjpFg0Cs/q2umEcfXgD7aq9Dj9h5KLTlsNBo2TnBZ9A HV/1UueVaEBTV5MBs9zINjS6F9vxzfWNGJeuYhrJBT8Ir4yqJsflIfwc7Lp37wRg8Q qkqaVH9zD+oMKfO9uKJ35AxGjS6SryFdoaIM/KagTnNilFCs1U2tobfQAIsvUVDvi6 FN8pkpZz90uTJJH+2ghibilscbE1dJ2nVHQN60yrM7ozTgwFVLCMO/6CYR6SMpzHbs dfYyKSBIYJiJA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tR7Yi-007CZr-OZ; Fri, 27 Dec 2024 10:27:08 +0000 Date: Fri, 27 Dec 2024 10:27:07 +0000 Message-ID: <86ldw1pgjo.wl-maz@kernel.org> From: Marc Zyngier To: FUKAUMI Naoki Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, tglx@linutronix.de, jonas@kwiboo.se, macromorgan@hotmail.com, andyshrk@163.com, liujianfeng1994@gmail.com, dmt.yashin@gmail.com, dsimic@manjaro.org, tim@feathertop.org, marcin.juszkiewicz@linaro.org, michael.riesch@wolfvision.net, alchark@gmail.com, sebastian.reichel@collabora.com, jbx6244@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add Radxa E52C In-Reply-To: <5EDFB980DF778743+9f26c8cc-d86d-46ed-9642-cdca10fe7e91@radxa.com> References: <20241222030355.2246-1-naoki@radxa.com> <20241222030355.2246-4-naoki@radxa.com> <87zfkmrb4u.wl-maz@kernel.org> <5EDFB980DF778743+9f26c8cc-d86d-46ed-9642-cdca10fe7e91@radxa.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: naoki@radxa.com, heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, tglx@linutronix.de, jonas@kwiboo.se, macromorgan@hotmail.com, andyshrk@163.com, liujianfeng1994@gmail.com, dmt.yashin@gmail.com, dsimic@manjaro.org, tim@feathertop.org, marcin.juszkiewicz@linaro.org, michael.riesch@wolfvision.net, alchark@gmail.com, sebastian.reichel@collabora.com, jbx6244@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 23 Dec 2024 10:16:04 +0000, FUKAUMI Naoki wrote: > > Hi Marc, > > On 12/23/24 18:39, Marc Zyngier wrote: > > On Sun, 22 Dec 2024 03:03:55 +0000, > > FUKAUMI Naoki wrote: > >> > >> Radxa E52C is a compact network computer[1] based on the Rockchip > >> RK3582 SoC: > >> > >> - Dual Cortex-A76 and quad Cortex-A55 CPU > > > > So you have *two* big cores. > > > >> - 5TOPS NPU > >> - 2GB/4GB/8GB LPDDR4 RAM > >> - 16GB/32GB/64GB on-board eMMC > >> - microSD card slot > >> - USB 3.0 Type-A HOST port > >> - USB Type-C debug port > >> - USB Type-C power port (5V only) > >> - 2x 2.5GbE ports > >> > >> [1] https://radxa.com/products/network-computer/e52c > >> > >> Signed-off-by: FUKAUMI Naoki > >> --- > >> arch/arm64/boot/dts/rockchip/Makefile | 1 + > >> .../boot/dts/rockchip/rk3582-radxa-e52c.dts | 729 ++++++++++++++++++ > >> 2 files changed, 730 insertions(+) > >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts > > > > [...] > > > >> +&cpu_b0 { > >> + cpu-supply = <&vdd_cpu_big0_s0>; > >> +}; > >> + > >> +&cpu_b1 { > >> + cpu-supply = <&vdd_cpu_big0_s0>; > >> +}; > >> + > >> +&cpu_b2 { > >> + cpu-supply = <&vdd_cpu_big1_s0>; > >> +}; > >> + > >> +&cpu_b3 { > >> + cpu-supply = <&vdd_cpu_big1_s0>; > >> +}; > > > > And yet you configure 4. If your HW only has 2 A76s, surely something > > should remove these cores for this platform rather than keep them > > around. > > One of the four cores may be defective. This information is stored in > the OTP, so we need to run our software to detect which core is > defective. Then we disable the cluster that contains the defective > core. Is it one? Is it two? If anything, this sort of binning information should be clearly explained in the cover letter, and a comment placed in the DTS file to explain that the DT needs to be further processed by the bootloader to be valid. M. -- Without deviation from the norm, progress is not possible.