From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69693C47247 for ; Tue, 5 May 2020 18:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4607820721 for ; Tue, 5 May 2020 18:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588703143; bh=jzIUsSLxN9/RqRoiWQZZrzjBGLn9x2XEbfuMss1MUYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=aeuMCBihtyNKWK5llC/+gTuKyLFaYBcl8pVC6MHjPgzudCJBxmRLvt/+BB7vzzVpW Q3hxlw1DJ+4B/HoAhpQL9kM6WG19yj9aviKCEuISy33UspYmUHTm+/IFj0tAuUAVD2 NPO0WBhViEICocYkL5tlRlzjfu8MBYHenG9tsT+A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728233AbgEESZm (ORCPT ); Tue, 5 May 2020 14:25:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:36706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728135AbgEESZm (ORCPT ); Tue, 5 May 2020 14:25:42 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F77D20663; Tue, 5 May 2020 18:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588703141; bh=jzIUsSLxN9/RqRoiWQZZrzjBGLn9x2XEbfuMss1MUYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vttHBMHHF6Y3uQLnQ6fIYJtl8ebDcYYt3ObBGn5wTjdl0Y1VStUTA3MZauO+EJKJe qM3N0g1HMq1wHzaemj80+Ei8WhHJi65BwgUiwoq/n2/74uklztDpK2C+lokjGoYXQ2 VQ2C29FgyAt1rIYqsiqRsUnX3fspdm/3elUS07zs= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=big-swifty.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jW2GB-009bx4-Te; Tue, 05 May 2020 19:25:40 +0100 Date: Tue, 05 May 2020 19:25:32 +0100 Message-ID: <86lfm6tf1f.wl-maz@kernel.org> From: Marc Zyngier To: Andre Przywara Cc: Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland Subject: Re: [PATCH 07/16] arm64: dts: arm: Fix GIC compatible names In-Reply-To: <20200505165212.76466-8-andre.przywara@arm.com> References: <20200505165212.76466-1-andre.przywara@arm.com> <20200505165212.76466-8-andre.przywara@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: andre.przywara@arm.com, robh@kernel.org, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 05 May 2020 17:52:03 +0100, Andre Przywara wrote: > > The GIC DT binding only allows a certain combination of DT compatible > strings, mostly just consisting of one name. > > Drop the combination of multiple names and go with the > "arm,cortex-a15-gic" name for GICv2, as this seems to be the most widely > accepted string. "arm,gic-400" would be more correct, but was introduced > much later into the kernel's GIC driver. > > Signed-off-by: Andre Przywara > --- > arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi | 2 +- > arch/arm64/boot/dts/arm/juno-base.dtsi | 2 +- > arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > index 15fe81738e94..61a1750fcdd6 100644 > --- a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > +++ b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi > @@ -6,7 +6,7 @@ > > / { > gic: interrupt-controller@2c001000 { > - compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > + compatible = "arm,cortex-a15-gic"; > #interrupt-cells = <3>; > #address-cells = <2>; > interrupt-controller; > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 3feefd61eb76..62392ab1f880 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -69,7 +69,7 @@ > }; > > gic: interrupt-controller@2c010000 { > - compatible = "arm,gic-400", "arm,cortex-a15-gic"; > + compatible = "arm,cortex-a15-gic"; Why? GIC-400 is definitely the most correct compatible string. I'd rather see this compatible being generalised to the models rather than only referencing the A15 GIC. > reg = <0x0 0x2c010000 0 0x1000>, > <0x0 0x2c02f000 0 0x2000>, > <0x0 0x2c04f000 0 0x2000>, > diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > index c5d15cbd8cf6..f86f6451411f 100644 > --- a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > +++ b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > @@ -95,7 +95,7 @@ > }; > > gic: interrupt-controller@2c001000 { > - compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > + compatible = "arm,cortex-a15-gic"; > #interrupt-cells = <3>; > #address-cells = <0>; > interrupt-controller; > -- > 2.17.1 > > Thanks, M. -- Jazz is not dead, it just smells funny.