From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C460282EE for ; Sun, 22 Dec 2024 09:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734858274; cv=none; b=B/zC0gcwJPyfFenkZkyb2MtQ6OIbYwZn/GUJnSAiQ5VxrPWVFXhxEWuqxCJ8WHEkHu1YPB5ym6BdmB4ah76mokHWDJHI8VwEygnZGDq2cV/+R1UocflzHhRtvX40PF7fk4aOxa799Jgd0oYG2yjlcY2OvCLWpXYcEXA+BjZzV+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734858274; c=relaxed/simple; bh=YREXXVGelktufefaexDX5YisyWqh+kibqX1uCmkxZjY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=nWhoNcDckRFUgMy4O3LLqjb57xmvgiuPol+3OpTD5wfQzEAIJyoVxMErRpS+CN/8mQjZmrj2jtkWur5uOBmJqTUaasgZMsM3I+LYFL4F3THNgjwjOVlcU8Nat8Joc3cuqSqjneWowJAQ4Obeok0z+ILD6hbZngpjzFuTF+P2O+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yx5iqp74; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yx5iqp74" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 983A4C4CECD; Sun, 22 Dec 2024 09:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734858273; bh=YREXXVGelktufefaexDX5YisyWqh+kibqX1uCmkxZjY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Yx5iqp74ji8DZMvo5j9hE0gLbm1Dlv8qjoGduuD7q8GsNS3vyZlPFXXLzgtDaRzl9 CAEHxHrtX+H/l778kvyNdh60piKmC8XNdiV0BGuukdxkdkxP5RboeGlIGcZYzsaWJk t/sc0AqUZy9jJxFWk5d1COKY+DrcXtCMiHloJxNFyGzYWXYbWjz2mMK+FoPlRopyeE jPG1pCvv8VYajRihhkMCMavKoOUX/5ZfjBW+JzOQcrOszoIj191OvfblmPqHnc6RZ7 qOI/eOR14mcFE4t1HzvDQNABVv2ctGv4+BPbe2vQ19DkywKaZHZ9MezaBDl95CUC7/ wKcMrDyqmHZRw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tPHt0-0067Ay-SY; Sun, 22 Dec 2024 09:04:31 +0000 Date: Sun, 22 Dec 2024 09:04:29 +0000 Message-ID: <86msgoozqa.wl-maz@kernel.org> From: Marc Zyngier To: FUKAUMI Naoki Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, tglx@linutronix.de, jonas@kwiboo.se, macromorgan@hotmail.com, andyshrk@163.com, liujianfeng1994@gmail.com, dmt.yashin@gmail.com, dsimic@manjaro.org, tim@feathertop.org, marcin.juszkiewicz@linaro.org, michael.riesch@wolfvision.net, alchark@gmail.com, sebastian.reichel@collabora.com, jbx6244@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/3] irqchip/gic-v3: Enable Rockchip 3588001 erratum workaround for RK3582 In-Reply-To: <20241222030355.2246-2-naoki@radxa.com> References: <20241222030355.2246-1-naoki@radxa.com> <20241222030355.2246-2-naoki@radxa.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: naoki@radxa.com, heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, tglx@linutronix.de, jonas@kwiboo.se, macromorgan@hotmail.com, andyshrk@163.com, liujianfeng1994@gmail.com, dmt.yashin@gmail.com, dsimic@manjaro.org, tim@feathertop.org, marcin.juszkiewicz@linaro.org, michael.riesch@wolfvision.net, alchark@gmail.com, sebastian.reichel@collabora.com, jbx6244@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 22 Dec 2024 03:03:53 +0000, FUKAUMI Naoki wrote: > > Rockchip RK3582 is a scaled down version of Rockchip RK3588(S). Apply > Rockchip 3588001 erratum workaround to RK3582. > > Signed-off-by: FUKAUMI Naoki > --- > drivers/irqchip/irq-gic-v3-its.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 92244cfa0464..c59ce9332dc0 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -4861,7 +4861,8 @@ static bool __maybe_unused its_enable_rk3588001(void *data) > { > struct its_node *its = data; > > - if (!of_machine_is_compatible("rockchip,rk3588") && > + if (!of_machine_is_compatible("rockchip,rk3582") && > + !of_machine_is_compatible("rockchip,rk3588") && > !of_machine_is_compatible("rockchip,rk3588s")) > return false; > Please use the relevant property for that purpose ("dma-noncoherent") at the distributor and ITS levels. We're not adding extra compatibles for this anymore, and you might as well fix the core dtsi to expose such property. Thanks, M. -- Without deviation from the norm, progress is not possible.