From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57DDC0015E for ; Fri, 23 Jun 2023 12:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbjFWMuA (ORCPT ); Fri, 23 Jun 2023 08:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbjFWMtx (ORCPT ); Fri, 23 Jun 2023 08:49:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E4B10C1; Fri, 23 Jun 2023 05:49:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFC9961A41; Fri, 23 Jun 2023 12:49:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3191BC433C0; Fri, 23 Jun 2023 12:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687524591; bh=9jQs0S7PGplotxU57o2pvvL0Cr/c4F03tmay59rArwI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j8Wqa0v9XlimtVUmIin2dvD0fnRgMA7b4U28B0NWLIDYi1qvR9Ktx3/8v1bgNf5Jh HXGZJIVO9MqsoeCUlVQBZWxz9SWcRaiySP/HwRetmN15uXQOb9Ky2YLq2OggS/c1Gi 1pO51CHvYn1hpFtK5Axn8lM8rsJlrINOm/fPDGowDJCoPORW0aDyoeIPo6yBrHYyJQ E+4jyW7yToQsA2gz8bEkPRf+MRoL9N/WHa2ClDP//nL1rltx+/wFc7V83nU9tF0ATe ZNtYzPE4oUmNiv/Q83eqM9P9SmtXG23njnA/JfHPq8lhd1sDQtJBy3wuE0+WLATwjb VYeKusnC6qG/Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qCgEW-007keF-Ga; Fri, 23 Jun 2023 13:49:48 +0100 Date: Fri, 23 Jun 2023 13:49:47 +0100 Message-ID: <86mt0qbaxg.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Saravana Kannan , Anup Patel , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Robin Murphy , Joerg Roedel , Will Deacon , Frank Rowand , Atish Patra , Andrew Jones , Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev, Android Kernel Team Subject: Re: [PATCH v4 08/10] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230613153415.350528-1-apatel@ventanamicro.com> <20230613153415.350528-9-apatel@ventanamicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, saravanak@google.com, anup@brainfault.org, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, frowand.list@gmail.com, atishp@atishpatra.org, ajones@ventanamicro.com, conor@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org [here, let me trim all of this nonsense...] On Fri, 23 Jun 2023 12:47:00 +0100, Anup Patel wrote: > > No. My previous email asking you to NOT use IRQCHIP_DECLARE() and > > instead use IRQCHIP_PLATFORM_DRIVER_BEGIN/END() macros. > > I tried IRQCHIP_PLATFORM_DRIVER_BEGIN/END() macros but these > macros are not suitable for APLIC driver because we need platform device > pointer in the APLIC probe() to create platform MSI device domain (refer, > platform_msi_create_device_domain()). Oh come on. How hard have you tried? Have you even looked at the other drivers in the tree to see how they solve this insurmountable problem with a *single* line of code? pdev = of_find_device_by_node(node); That's it. > Further, I tried setting the "suppress_bind_attrs" flag in "struct > platform_driver aplic_driver" just like the > IRQCHIP_PLATFORM_DRIVER_END() macro but this did not work. I'm not sure how relevant this is to the conversation. M. -- Without deviation from the norm, progress is not possible.