From: Marc Zyngier <maz@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, diasyzhang@tencent.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: loongson,liointc: Fix warnings about liointc-2.0
Date: Mon, 04 Sep 2023 09:54:53 +0100 [thread overview]
Message-ID: <86pm2ye2si.wl-maz@kernel.org> (raw)
In-Reply-To: <c7898abf-34ca-d0b4-fd0c-935100dcd3f2@flygoat.com>
On Wed, 30 Aug 2023 16:25:48 +0100,
Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>
>
>
> 在 2023/8/30 21:44, Marc Zyngier 写道:
> [...]
> >> What's the best way, in your opinion, to overhaul this property? As we don't
> >> really care backward compatibility of DTBs on those systems we can
> >> just redesign it.
> > You may not care about backward compatibility, but I do. We don't
> > break existing systems, full stop.
> Ah it won't break any existing system. Sorry for not giving enough insight
> into the platform in previous reply. As for Loongson64 all DTBs are built
> into kernel binary. So as long as binding are changed together with all DTS
> in tree we won't break any system.
This is factually wrong. QEMU produces a DT for Loongarch at runtime.
So no, you're not allowed to just drop bindings on the floor. They
stay forever.
> > As for the offending property, it has no place here either. DT is not
> > the place where you put "performance knobs".
> Hmm, I can see various bindings with vendor prefix exposing device
> configurations. If we seen this interrupt routing as a device configuration
> I don't think it's against devicetree design philosophy.
Just because we have tons of crap in the device trees doesn't give you
a license to be just as bad.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-09-04 8:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 6:13 [PATCH v2] dt-bindings: interrupt-controller: loongson,liointc: Fix warnings about liointc-2.0 Binbin Zhou
2023-08-22 4:44 ` Huacai Chen
2023-08-22 5:44 ` Krzysztof Kozlowski
2023-08-22 8:13 ` Binbin Zhou
2023-08-22 8:30 ` Krzysztof Kozlowski
2023-08-24 11:32 ` Binbin Zhou
2023-08-25 12:56 ` Krzysztof Kozlowski
2023-08-30 3:59 ` Jiaxun Yang
2023-08-30 13:44 ` Marc Zyngier
2023-08-30 15:25 ` Jiaxun Yang
2023-09-04 8:54 ` Marc Zyngier [this message]
2023-10-16 11:26 ` Binbin Zhou
2023-10-17 15:05 ` Jonas Gorski
2023-10-18 6:57 ` Binbin Zhou
2023-10-18 9:38 ` Jonas Gorski
2023-10-18 14:33 ` Huacai Chen
2023-10-20 9:51 ` Binbin Zhou
2023-10-20 12:18 ` Marc Zyngier
2023-10-25 1:56 ` Huacai Chen
2023-10-25 7:16 ` Krzysztof Kozlowski
2023-10-26 7:19 ` Huacai Chen
2023-10-29 7:42 ` Krzysztof Kozlowski
2023-10-30 9:56 ` Binbin Zhou
2023-08-30 14:35 ` Krzysztof Kozlowski
2023-08-30 15:31 ` Jiaxun Yang
2023-08-31 1:47 ` Binbin Zhou
2023-09-02 6:32 ` Jianmin Lv
2023-09-04 7:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pm2ye2si.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diasyzhang@tencent.com \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).