[PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since most X1E device trees just mirror the power supplies from the
x1e80100-crd device tree, this series fixes up all the X1E boards with
the same change.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Stephan Gerhold (8):
      arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies
      arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies

 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts               | 6 +++---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts    | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-crd.dts                  | 6 +++---
 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts      | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 6 +++---
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi   | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                  | 6 +++---
 8 files changed, 20 insertions(+), 20 deletions(-)
---
base-commit: f2b086fc9f039773445d2606dc65dc091ec1830f
change-id: 20241115-x1e80100-usb-qmp-supply-fix-5cc5e39a7d02

Best regards,
-- 
Stephan Gerhold <stephan.gerhold@linaro.org>

[PATCH 1/8] arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since x1e001de-devkit mostly just mirrors the power supplies from the
x1e80100-crd device tree, assume that the fix also applies here.

Cc: stable@vger.kernel.org
Fixes: 7b8a31e82b87 ("arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index c9db6298d528ed505bae08e91bf4da02faef7d76..8eb80ecd36990ee39005bfd583e0b3e331de5374 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -1255,7 +1255,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p8>;
 
 	status = "okay";
@@ -1288,7 +1288,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";
@@ -1320,7 +1320,7 @@ &usb_1_ss2_hsphy {
 };
 
 &usb_1_ss2_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

[PATCH 2/8] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since x1e78100-lenovo-thinkpad-t14s mostly just mirrors the power supplies
from the x1e80100-crd device tree, assume that the fix also applies here.

Cc: stable@vger.kernel.org
Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
index 975550139e1024420ed335a2a46e4d54df7ee423..86762f555979d96fbaaf325b210c196e711b3635 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
@@ -763,7 +763,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p8>;
 
 	status = "okay";
@@ -791,7 +791,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

[PATCH 3/8] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since x1e80100-asus-vivobook-s15 mostly just mirrors the power supplies
from the x1e80100-crd device tree, assume that the fix also applies here.

Cc: stable@vger.kernel.org
Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
index f25991b887de3fca0092c5f81c881c5d8bd71aac..bcb25782d541f43166229695ea1b83ee7b94a6c8 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
@@ -599,7 +599,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p8>;
 
 	status = "okay";
@@ -631,7 +631,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

Re: [PATCH 3/8] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies

[Maud Spierings]

On 12/10/24 10:07, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
>
> Since x1e80100-asus-vivobook-s15 mostly just mirrors the power supplies
> from the x1e80100-crd device tree, assume that the fix also applies here.
>
> Cc: stable@vger.kernel.org
> Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> index f25991b887de3fca0092c5f81c881c5d8bd71aac..bcb25782d541f43166229695ea1b83ee7b94a6c8 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> @@ -599,7 +599,7 @@ &usb_1_ss0_hsphy {
>   };
>   
>   &usb_1_ss0_qmpphy {
> -	vdda-phy-supply = <&vreg_l3e_1p2>;
> +	vdda-phy-supply = <&vreg_l2j_1p2>;
>   	vdda-pll-supply = <&vreg_l1j_0p8>;
>   
>   	status = "okay";
> @@ -631,7 +631,7 @@ &usb_1_ss1_hsphy {
>   };
>   
>   &usb_1_ss1_qmpphy {
> -	vdda-phy-supply = <&vreg_l3e_1p2>;
> +	vdda-phy-supply = <&vreg_l2j_1p2>;
>   	vdda-pll-supply = <&vreg_l2d_0p9>;
>   
>   	status = "okay";
>
I can't really verify with documentation if it is actually correct but 
given the similarities in all these systems I have no reason to assume not.

It doesn't seem to cause any weird errors or anything, so


Tested-by: Maud Spierings <maud_spierings@hotmail.com>

[PATCH 4/8] arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Cc: stable@vger.kernel.org
Fixes: ae5cee8e7349 ("arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index 39f9d9cdc10d8e79824b72288e2529536144fa9e..401326123db6619552b9ff2b90aa16dbb6649b92 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -1187,7 +1187,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p8>;
 
 	status = "okay";
@@ -1215,7 +1215,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";
@@ -1243,7 +1243,7 @@ &usb_1_ss2_hsphy {
 };
 
 &usb_1_ss2_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

[PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies from
the x1e80100-crd device tree, assume that the fix also applies here.

Cc: stable@vger.kernel.org
Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
index b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a43adec291a31f9beed 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
@@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p9>;
 
 	status = "okay";
@@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

Re: [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies

[Aleksandrs Vinarskis]

On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold
<stephan.gerhold@linaro.org> wrote:
>
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
>
> Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies from
> the x1e80100-crd device tree, assume that the fix also applies here.

Though I can't verify schematics (perhaps Laurentiu can?), can confirm
USBs still work as expected with this change.

Tested-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>

>
> Cc: stable@vger.kernel.org
> Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a43adec291a31f9beed 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy {
>  };
>
>  &usb_1_ss0_qmpphy {
> -       vdda-phy-supply = <&vreg_l3e_1p2>;
> +       vdda-phy-supply = <&vreg_l2j_1p2>;
>         vdda-pll-supply = <&vreg_l1j_0p9>;
>
>         status = "okay";
> @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy {
>  };
>
>  &usb_1_ss1_qmpphy {
> -       vdda-phy-supply = <&vreg_l3e_1p2>;
> +       vdda-phy-supply = <&vreg_l2j_1p2>;
>         vdda-pll-supply = <&vreg_l2d_0p9>;
>
>         status = "okay";
>
> --
> 2.47.0
>

RE: [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies

[Tudor, Laurentiu]

Internal Use - Confidential
> -----Original Message-----
> From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> Sent: Tuesday, December 10, 2024 10:45 PM
>
> On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold <stephan.gerhold@linaro.org>
> wrote:
> >
> > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e.
> > USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 are
> > actually powered by &vreg_l2j_1p2.
> >
> > Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies
> > from the x1e80100-crd device tree, assume that the fix also applies here.
>
> Though I can't verify schematics (perhaps Laurentiu can?)can confirm USBs
> still work as expected with this change.

Yep, just checked the schematics and can confirm.

---
Best Regards, Laurentiu

> Tested-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
>
> >
> > Cc: stable@vger.kernel.org
> > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell
> > XPS 13 9345")
> > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> > b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> > index
> >
> b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a4
> 3adec
> > 291a31f9beed 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> > @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy {  };
> >
> >  &usb_1_ss0_qmpphy {
> > -       vdda-phy-supply = <&vreg_l3e_1p2>;
> > +       vdda-phy-supply = <&vreg_l2j_1p2>;
> >         vdda-pll-supply = <&vreg_l1j_0p9>;
> >
> >         status = "okay";
> > @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy {  };
> >
> >  &usb_1_ss1_qmpphy {
> > -       vdda-phy-supply = <&vreg_l3e_1p2>;
> > +       vdda-phy-supply = <&vreg_l2j_1p2>;
> >         vdda-pll-supply = <&vreg_l2d_0p9>;
> >
> >         status = "okay";
> >
> > --
> > 2.47.0
> >

Re: [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies

[Johan Hovold]

On Wed, Dec 11, 2024 at 11:35:37AM +0000, Tudor, Laurentiu wrote:
> 
> Internal Use - Confidential

Looks like you need to fix your mail setup for when you're interacting
with the community and mailing lists.

> > -----Original Message-----
> > From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> > Sent: Tuesday, December 10, 2024 10:45 PM
> >
> > On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold <stephan.gerhold@linaro.org>
> > wrote:
> > >
> > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > (i.e.
> > > USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 are
> > > actually powered by &vreg_l2j_1p2.
> > >
> > > Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies
> > > from the x1e80100-crd device tree, assume that the fix also applies here.
> >
> > Though I can't verify schematics (perhaps Laurentiu can?)can confirm USBs
> > still work as expected with this change.
> 
> Yep, just checked the schematics and can confirm.

Thanks for confirming.

Johan

[PATCH 6/8] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since x1e80100-lenovo-yoga-slim7x mostly just mirrors the power supplies
from the x1e80100-crd device tree, assume that the fix also applies here.

Cc: stable@vger.kernel.org
Fixes: 45247fe17db2 ("arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index ca5a808f2c7df66a861a933df407fd4bdaea3fe1..77908462aef6607439b8e950439a4c4ef9833b57 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -908,7 +908,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p8>;
 
 	status = "okay";
@@ -940,7 +940,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";
@@ -972,7 +972,7 @@ &usb_1_ss2_hsphy {
 };
 
 &usb_1_ss2_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

[PATCH 7/8] arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Since x1e80100-microsoft-romulus mostly just mirrors the power supplies
from the x1e80100-crd device tree, assume that the fix also applies here.

Cc: stable@vger.kernel.org
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index 2236095023a135d8fb1baaede111a34be54d160c..618d73fe3fa94d935f4bfeeb71973b4a2e7ce0cd 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -1322,7 +1322,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e>;
+	vdda-phy-supply = <&vreg_l2j>;
 	vdda-pll-supply = <&vreg_l1j>;
 
 	status = "okay";
@@ -1354,7 +1354,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e>;
+	vdda-phy-supply = <&vreg_l2j>;
 	vdda-pll-supply = <&vreg_l2d>;
 
 	status = "okay";

-- 
2.47.0

Re: [PATCH 7/8] arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies

[Konrad Dybcio]

On 10.12.2024 10:07 AM, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
> 
> Since x1e80100-microsoft-romulus mostly just mirrors the power supplies
> from the x1e80100-crd device tree, assume that the fix also applies here.
> 
> Cc: stable@vger.kernel.org
> Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---

I'm just going to assume these are true.. Can't really cut power to
these to test as they drive many more things

Konrad

[PATCH 8/8] arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies

[Stephan Gerhold]

On the X1E80100 QCP, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
(i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
are actually powered by &vreg_l2j_1p2.

Cc: stable@vger.kernel.org
Fixes: 20676f7819d7 ("arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 5ef030c60abe2998d093ee60a6754a90cd5aaf72..af76aa034d0e17622ab738bfcb25536764416eff 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -896,7 +896,7 @@ &usb_1_ss0_hsphy {
 };
 
 &usb_1_ss0_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l1j_0p8>;
 
 	status = "okay";
@@ -928,7 +928,7 @@ &usb_1_ss1_hsphy {
 };
 
 &usb_1_ss1_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";
@@ -960,7 +960,7 @@ &usb_1_ss2_hsphy {
 };
 
 &usb_1_ss2_qmpphy {
-	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-phy-supply = <&vreg_l2j_1p2>;
 	vdda-pll-supply = <&vreg_l2d_0p9>;
 
 	status = "okay";

-- 
2.47.0

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[Johan Hovold]

On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
> 
> Since most X1E device trees just mirror the power supplies from the
> x1e80100-crd device tree, this series fixes up all the X1E boards with
> the same change.

Nice find! I've confirmed that this matches both the CRD and T14s
schematics.

> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>

> Stephan Gerhold (8):
>       arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies

nit: We've been using the shorter "x1e78100-t14s" prefix for this one so
far. This may apply to some of the others as well.

>       arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies
>       arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Johan

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[Marc Zyngier]

On Tue, 10 Dec 2024 13:18:20 +0000,
Johan Hovold <johan@kernel.org> wrote:
> 
> On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> > are actually powered by &vreg_l2j_1p2.
> > 
> > Since most X1E device trees just mirror the power supplies from the
> > x1e80100-crd device tree, this series fixes up all the X1E boards with
> > the same change.
> 
> Nice find! I've confirmed that this matches both the CRD and T14s
> schematics.

Can someone with access to the schematics confirm that the devkit
indeed has the same supplies?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[Johan Hovold]

On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote:
> On Tue, 10 Dec 2024 13:18:20 +0000,
> Johan Hovold <johan@kernel.org> wrote:
> > 
> > On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
> > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> > > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> > > are actually powered by &vreg_l2j_1p2.
> > > 
> > > Since most X1E device trees just mirror the power supplies from the
> > > x1e80100-crd device tree, this series fixes up all the X1E boards with
> > > the same change.
> > 
> > Nice find! I've confirmed that this matches both the CRD and T14s
> > schematics.
> 
> Can someone with access to the schematics confirm that the devkit
> indeed has the same supplies?

Sibi, can you confirm our assumption that these definitions were copied
from the CRD devicetree and need to be fixed like this also for the
devkit?

Johan

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[Konrad Dybcio]

On 10.12.2024 4:38 PM, Johan Hovold wrote:
> On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote:
>> On Tue, 10 Dec 2024 13:18:20 +0000,
>> Johan Hovold <johan@kernel.org> wrote:
>>>
>>> On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote:
>>>> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
>>>> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
>>>> are actually powered by &vreg_l2j_1p2.
>>>>
>>>> Since most X1E device trees just mirror the power supplies from the
>>>> x1e80100-crd device tree, this series fixes up all the X1E boards with
>>>> the same change.
>>>
>>> Nice find! I've confirmed that this matches both the CRD and T14s
>>> schematics.
>>
>> Can someone with access to the schematics confirm that the devkit
>> indeed has the same supplies?
> 
> Sibi, can you confirm our assumption that these definitions were copied
> from the CRD devicetree and need to be fixed like this also for the
> devkit?

I can confirm the fix applies to devkit too.

Konrad

Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies

[Bjorn Andersson]

On Tue, 10 Dec 2024 10:07:31 +0100, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
> 
> Since most X1E device trees just mirror the power supplies from the
> x1e80100-crd device tree, this series fixes up all the X1E boards with
> the same change.
> 
> [...]

Applied, thanks!

[1/8] arm64: dts: qcom: x1e001de-devkit: Fix USB QMP PHY supplies
      commit: 21aceb8153dfb5560655e01192304db670959c88
[2/8] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: Fix USB QMP PHY supplies
      commit: 6efc01b75f819a2988aa9392f93a4d6501871525
[3/8] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies
      commit: bf5e9aa844ca74e9c202d8de2ce7390d24ec38a4
[4/8] arm64: dts: qcom: x1e80100-crd: Fix USB QMP PHY supplies
      commit: 789209dd08124da448bfa7524b21049a04d98f83
[5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies
      commit: 26a1b22aaf0c6f5128f8d0242caf3d983d5a2836
[6/8] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix USB QMP PHY supplies
      commit: 6ba8e1b8242d27dd83ed4ce58a104c709e72f45f
[7/8] arm64: dts: qcom: x1e80100-microsoft-romulus: Fix USB QMP PHY supplies
      commit: c0562f51b177d49829a378b5aeda73f78c60d0fc
[8/8] arm64: dts: qcom: x1e80100-qcp: Fix USB QMP PHY supplies
      commit: 4861ba7cf5a49969dee258dda2bf8d4e819135d1

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>