devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Ball <chris@printf.net>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org,
	Phil Edworthy <phil.edworthy@renesas.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v4] mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller
Date: Wed, 11 Jun 2014 23:07:09 +0100	[thread overview]
Message-ID: <86tx7rm776.fsf@void.printf.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1406112218060.2586@axis700.grange> (Guennadi Liakhovetski's message of "Wed, 11 Jun 2014 22:20:07 +0200 (CEST)")

Hi,

On Wed, Jun 11 2014, Guennadi Liakhovetski wrote:
>> Please send fixes for the compiler warnings, potential-null mrq,
>
> Sure, it's on my todo for Saturday, is this ok?

Cool, thanks.

>> and
>> perhaps add an ARCH_ dependency to stop this building on x86_64.
>
> Is there a specific reason to only build it on ARM? It can be used with 
> various architectures, but we can make it depend on COMPILE_TEST (or 
> whatever that option is called), but I'm not sure that's required.

Mainly that it looked like it wasn't intended for 64-bit systems,
but if that's untrue then I guess it's okay to leave it building.
Of course, you could depend on each of the architectures you're
aware of it being potentially used on, rather than just ARM.

- Chris.
-- 
Chris Ball   <http://printf.net/>

      reply	other threads:[~2014-06-11 22:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 18:38 [PATCH v4] mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller Guennadi Liakhovetski
2014-06-03  1:26 ` Chris Ball
2014-06-11 19:08 ` Chris Ball
2014-06-11 20:20   ` Guennadi Liakhovetski
2014-06-11 22:07     ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tx7rm776.fsf@void.printf.net \
    --to=chris@printf.net \
    --cc=devicetree@vger.kernel.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=grant.likely@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).