From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v4] mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller Date: Wed, 11 Jun 2014 23:07:09 +0100 Message-ID: <86tx7rm776.fsf@void.printf.net> References: <86y4x3mfhc.fsf@void.printf.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Guennadi Liakhovetski's message of "Wed, 11 Jun 2014 22:20:07 +0200 (CEST)") Sender: linux-mmc-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, Phil Edworthy , devicetree@vger.kernel.org, Rob Herring , Grant Likely , Ulf Hansson List-Id: devicetree@vger.kernel.org Hi, On Wed, Jun 11 2014, Guennadi Liakhovetski wrote: >> Please send fixes for the compiler warnings, potential-null mrq, > > Sure, it's on my todo for Saturday, is this ok? Cool, thanks. >> and >> perhaps add an ARCH_ dependency to stop this building on x86_64. > > Is there a specific reason to only build it on ARM? It can be used with > various architectures, but we can make it depend on COMPILE_TEST (or > whatever that option is called), but I'm not sure that's required. Mainly that it looked like it wasn't intended for 64-bit systems, but if that's untrue then I guess it's okay to leave it building. Of course, you could depend on each of the architectures you're aware of it being potentially used on, rather than just ARM. - Chris. -- Chris Ball