From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EC81331204; Thu, 5 Mar 2026 10:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772705637; cv=none; b=p2SOiWC9UcBh7z/Y8/AK2jfCXJ9Yk5qlDl8+qVjkhwL5+NmSjWzzyVR/E4xQ3U2X1DC+kQuGLqu2bWHXK0Mbm/3oAT/k4fWUmIZJsvBISq9ExX3HH9uFutbjRmtt2/b0vq/cH8oe+3jzaxuGnRVfNVGgUQUGJ7Zcx3Carqg9AcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772705637; c=relaxed/simple; bh=gLlEtYagEKIFjG5F8a3A/NR9PRdUS4OHscROMOIMXZA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=jcbEFctYv9Cgfbw27kGCh+gsj8XCP1/QN8m64Iobst3elptXHTd2f9+S3qUFTcA6oXGeKT3sFoTsE55/txW69zHsqyHJVVymq3M9XHCYqaf9p90KlwdtvlmBKKNrqN2aaYUeM/ndBCbt/wi0zdCIpuWTBBaZ3QG9r6qy1ewGCM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OGxx742k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OGxx742k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C52AEC116C6; Thu, 5 Mar 2026 10:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772705636; bh=gLlEtYagEKIFjG5F8a3A/NR9PRdUS4OHscROMOIMXZA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OGxx742ke8ndUq+KKpCoK78oYVQ+tBt9CF0nBSTEw5V6sjEK34QB1i75slSO+ilb5 bzv8SKdM+Aj941MheVLLmptyNHH2aZRlbMyfKcyximmU0Iqru503CIvVVpvKQewuVJ I1gkrYmmRNt70fhzjJFOJIBOr43VyqJZnMKOHmI4BpNrGBTGz3h27oyGs2gULFRa48 cK56WnPdi+Oq6gXwLZby4u/gIzKC/Y28ebuttCuqXyLbELbpasi/D2md3AQnhSl5BY P9X2qwHlg3WZH66oyHfOnWJ2bJhliZovnSdIh46cr0FMTHaQ40jjxu7XbWLeozpAnG I1rOHUQJMHF/Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vy5iM-0000000GOHR-0DfY; Thu, 05 Mar 2026 10:13:54 +0000 Date: Thu, 05 Mar 2026 10:13:53 +0000 Message-ID: <86v7fa7fdq.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , Antoine Tenart , Florian Fainelli , Broadcom internal kernel review list , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mark-PK Tsai , Daniel Palmer , Matthias Brugger , AngeloGioacchino Del Regno , Thierry Reding , Jonathan Hunter , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Kunihiko Hayashi , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/4] irqchip/gic: Use GIC_* DT binding definitions In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: geert+renesas@glider.be, tglx@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lpieralisi@kernel.org, atenart@kernel.org, florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, mark-pk.tsai@mediatek.com, daniel@thingy.jp, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, thierry.reding@gmail.com, jonathanh@nvidia.com, nm@ti.com, kristo@kernel.org, ssantosh@kernel.org, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 04 Mar 2026 17:21:58 +0000, Geert Uytterhoeven wrote: > > Replace magic numbers by symbolic DT binding definitions. This improves > readability, and makes it easier to find where the various GIC > interrupts types are handled. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/irqchip/irq-gic-v3.c | 14 ++++++++------ > drivers/irqchip/irq-gic.c | 6 ++++-- > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index d75163e71bf22473..6ac103cb40097acc 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -35,6 +35,8 @@ > #include > #include > > +#include > + > #include "irq-gic-common.h" > > static u8 dist_prio_irq __ro_after_init = GICV3_PRIO_IRQ; > @@ -1602,25 +1604,25 @@ static int gic_irq_domain_translate(struct irq_domain *d, > return -EINVAL; > > switch (fwspec->param[0]) { > - case 0: /* SPI */ > + case GIC_SPI: I'd rather not do that. I use *numeric* values on purpose, because that's what the DT *binding* describes, and I have no control over what lives in that include file (it gets changed without me being even Cc'd). So I want to stick to the binding, and not to the interpretation of it. If you want symbolic values to be used, describe them in the binding, have a tool to generate the values from the binding, and use that everywhere. Thanks, M. -- Without deviation from the norm, progress is not possible.