From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3563319CC1D; Thu, 31 Oct 2024 12:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730377784; cv=none; b=YYF06nNP/T3n2xNRrmCkz0SJRxLXyVOqUC12X05PVa6aZSc5P02KstSWenTjcXAb+kvbCLAie3ntsuJqVtliyyK6XnfQycWNskEBwQ2MQgPlWMaXJ/MtZxppWuX8HOxvatrgPzOzdJNoK/37ME11Vj54Vb8zvHGzab1YBk8jcec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730377784; c=relaxed/simple; bh=0pgnrKFCd7krk9HzGqlDXM26z+itSZVYEdeZBHDof1g=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=VPVsWh+ygioITjaRfCcauSYUr0qSKgoizo6XU0kl0NDZongt5Lojw/6OiJYhkR7F0UZ6MgkfzUTVgmpVRD5/AUALydcNfj2mUPhjRZp/2pYlH0G0mHn2yRf+PjQ422uzDKJc9FuE7u2STaUYIVKN2CAZ5Se2QRBYJ3ejcFjzjS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MaehoI2R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MaehoI2R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5382C4DDED; Thu, 31 Oct 2024 12:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730377783; bh=0pgnrKFCd7krk9HzGqlDXM26z+itSZVYEdeZBHDof1g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MaehoI2R2yl2V53Xv7oZeuswyGfMw7HTFfLGktq2oxSMwXSi/PmmLutEYJGJDGnmK MnkZTXH8ytwV4XK/UXmv03vEHrs9p5ZCZkQ5T7roMAN2HgYbeBzMzAx+NigK92oloe ahPylV40f9+BPXY1+1SSoMXkAhyJcBVta+Kpb1PL6D0X+/XCGTzE7uNECjdVcH1mNC RpqMSC25ktseTmZZvtyETRhZfTsWN1hl7KAkkRpuL21iQ1Tnn7YNJxQcTWNIqDDCXS Afq3t1HxSPoaS4thfeSEat5WJs6XoZyhWtS+K2UzckYFyqrmUANgHBmkUfqo0V29+G TRQR+IMfw86vQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t6UJ3-008YcM-DV; Thu, 31 Oct 2024 12:29:41 +0000 Date: Thu, 31 Oct 2024 12:29:40 +0000 Message-ID: <86v7x81mmj.wl-maz@kernel.org> From: Marc Zyngier To: Abel Vesa , Jens Glathe Cc: Sibi Sankar , andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org, dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, srinivas.kandagatla@linaro.org, quic_jjohnson@quicinc.com Subject: Re: [PATCH V3 0/3] X1E001DE Snapdragon Devkit for Windows In-Reply-To: <5d8ec8c4-f473-4849-a428-f7a7283ff478@oldschoolsolutions.biz> References: <20241025123227.3527720-1-quic_sibis@quicinc.com> <86y1251q3b.wl-maz@kernel.org> <5d8ec8c4-f473-4849-a428-f7a7283ff478@oldschoolsolutions.biz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: abel.vesa@linaro.org, jens.glathe@oldschoolsolutions.biz, quic_sibis@quicinc.com, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org, dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, srinivas.kandagatla@linaro.org, quic_jjohnson@quicinc.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 31 Oct 2024 10:00:40 +0000, Jens Glathe wrote: >=20 > On 31.10.24 10:46, Abel Vesa wrote: > > On 24-10-30 17:02:32, Marc Zyngier wrote: > >> On Fri, 25 Oct 2024 13:32:24 +0100, > >> Sibi Sankar wrote: > >>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E00= 1DE > >>> is the speed binned variant of X1E80100 that supports turbo boost up = to > >>> 4.3 Ghz. The initial support includes the following: > >>>=20 > >>> -DSPs > >>> -Ethernet (RTL8125BG) over the pcie 5 instance. > >>> -NVme > >>> -Wifi > >>> -USB-C ports > >>>=20 > >>> V3: > >>> * Asked around and looked at the firmware, couldn't find a codename so > >>> will keep it as DEVKIT. Will update it if someone from the communi= ty > >>> finds something else. > >> My machine has the following information as part of its DMI tables: > >>=20 > >> Handle 0x0005, DMI type 1, 27 bytes > >> System Information > >> Manufacturer: Qualcomm > >> Product Name: Snapdragon-Devkit > >> Version: 2.1 > >> Serial Number: 5 > >> UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 > >> Wake-up Type: Power Switch > >> SKU Number: 6 > >> Family: SCP_HAMOA > >>=20 > >> So I guess that Snapdragon-Devkit is another possible name. But given > >> that it is a bit of a mouthful, devkit, Devkit, or any other variation > >> on the case would work for me. > > The point was to have something unique A codename would be unique. > > Naming it Snapdragon-Devkit (or just devkit) will be confusing since > > there was already a 2023 devkit (from Microsoft) with the Snapdragon > > 8cx Gen 3, and probably the next compute platform will also have a devk= it > > as well. So probably "X Elite devkit" could be the right option.. Odd, I didn't get that email. My point was the the HW already comes with a full description as part of the existing tables. If you really want something that is truly unique to that platform and that can be used by a tool (be it firmware, kernel or userspace) to understand what it is running on, then you cannot have *less* information. At the very least, you would need Manufacturer, Product Name, Version and Family. But does it really matter? I don't think it is *that* crucial. At the end of the day, this is only used to pick the correct DT out of a set for a given SoC, or worse case a family of SoCs that are closely related. > As for The Windows Dev Kit 2023, dmidecode says this: >=20 > Handle 0x0009, DMI type 1, 27 bytes > System Information > =C2=A0=C2=A0 =C2=A0Manufacturer: Microsoft Corporation > =C2=A0=C2=A0 =C2=A0Product Name: Windows Dev Kit 2023 > =C2=A0=C2=A0 =C2=A0Version: 124I:00097T:000M:0200000B:07 > =C2=A0=C2=A0 =C2=A0Serial Number: 0F01C4F22373F6 > =C2=A0=C2=A0 =C2=A0UUID: e4a4662c-8367-75d0-a54f-1d04bd404860 > =C2=A0=C2=A0 =C2=A0Wake-up Type: Unknown > =C2=A0=C2=A0 =C2=A0SKU Number: 2043 > =C2=A0=C2=A0 =C2=A0Family: Surface >=20 > That's also really a mouthful. In my patchset for it there were some > name / path changes, microsoft/blackrock it is now. Would be cool to > have short and unique names. In the end, whatever works and is unique. > Like those UUIDs? Are those actually per platform? or per unit? On my box, the serial number is probably a dud. What does the UUID reports on your X1E box? Thanks, M. --=20 Without deviation from the norm, progress is not possible.