From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8513D68; Thu, 30 May 2024 13:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717077288; cv=none; b=UF4CwdHU7Mug6BUzB/Zkf1zffTpK2dcqAKB7fC2jrzZTbAikNqSRSCw17aSGdbeE/MTH6stI5bAhH+SJZdvVnL5XWDt8k8B6eJt8KeHf+8lfcp91YorttR1unCyb6GnAP5WWTD/v2XD9082hvx1Eon3cH41BXMOv7dPAOqr+1A4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717077288; c=relaxed/simple; bh=q3qGYkWoISiLK4CH2M4GGiP+fm0cRhpFmjJb9qqJnno=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=giu1KYgkJBfwtdYNxHpLOQQJMHIeSSyqWjuWQRyd8PcS1Ln/VSUCOBgIPEY/FGEQ13lkt5HGkLr5iUkUzKT0PfLxxJpJG6GR8P6s4svxkiECfe9lgywyk94PLDiM1ZnNmODLziHcERwV4C2NOxOFKQdCJKbWysgv7t5rj9kYLX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g61V7Een; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g61V7Een" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D09E0C2BBFC; Thu, 30 May 2024 13:54:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717077287; bh=q3qGYkWoISiLK4CH2M4GGiP+fm0cRhpFmjJb9qqJnno=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g61V7EenqhG+KV90gKh5/eSORsAYlgXDU9Kzj8sTwRLAJy4tEWHgtFONYSK8oh9+5 k4LdLjFbsZbUBUUVkgVoZtE6/K8Dm9DWYivHvowfBy1PryJvZezS1BpVtRGdhI2K5n k6ZJDalpk5MBwWzwU+zpZVCHCAYT9k/wazHsUDowSP7/U6CNvnjLtinmE5hxlVuq/1 5dwZBDqN4HwhpUjMTcwibhbpi2xfVPCqitLVfcz4XuaRbYJx71dolggH3RfaOO5V2w pBcaX4xGpwrEkpU8vZdf27Cr6hUUD8bYVZ520YwyfTtIF3PdYILK3dFvZoktgd/wUK uC4xBcvqBfMIQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sCgEv-00GuVb-Le; Thu, 30 May 2024 14:54:45 +0100 Date: Thu, 30 May 2024 14:54:44 +0100 Message-ID: <86wmnbl80r.wl-maz@kernel.org> From: Marc Zyngier To: "Rob Herring (Arm)" Cc: Saravana Kannan , Anup Patel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/2] of: Fix interrupt-map for fw_devlink In-Reply-To: <20240529-dt-interrupt-map-fix-v2-0-ef86dc5bcd2a@kernel.org> References: <20240529-dt-interrupt-map-fix-v2-0-ef86dc5bcd2a@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robh@kernel.org, saravanak@google.com, apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 29 May 2024 20:59:19 +0100, "Rob Herring (Arm)" wrote: > > The duplicated parsing continued to bother me, so I've refactored things > to avoid that for parsing the interrupt parent and args in the > interrupt-map. > > It passes testing with unittests on QEMU virt platform, but I don't > think that catches the problematic cases. So please test. > > v1: https://lore.kernel.org/all/20240528164132.2451685-1-maz@kernel.org/ > - Refactor existing interrupt-map parsing code and use it for > fw_devlink > > Signed-off-by: Rob Herring (Arm) > --- > Marc Zyngier (1): > of: property: Fix fw_devlink handling of interrupt-map > > Rob Herring (Arm) (1): > of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw() > > drivers/of/irq.c | 127 +++++++++++++++++++++++++++++------------------- > drivers/of/of_private.h | 3 ++ > drivers/of/property.c | 30 ++++-------- > 3 files changed, 89 insertions(+), 71 deletions(-) I've just gave it a go on an M1 and as a kvmtool guest, and nothing caught fire. Must be perfect. Tested-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.