From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06E0C83F01 for ; Wed, 30 Aug 2023 18:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236518AbjH3Sbx (ORCPT ); Wed, 30 Aug 2023 14:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244690AbjH3Nor (ORCPT ); Wed, 30 Aug 2023 09:44:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D3DA3; Wed, 30 Aug 2023 06:44:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B35562602; Wed, 30 Aug 2023 13:44:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B945AC433C8; Wed, 30 Aug 2023 13:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693403083; bh=lHfKq4d/r4SkrYm1cDQVZR/6CiTUPBxZkFaWTRcy388=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MqECSlqX6hFw56rkBs5PwaqxFW5vDHVOVW9fWeYcnkfsfOtiOWWsMM0vd7cVD1t32 cbL1l/BofoYTHcfwKWRKJEQY93zavSvuwj382K4kgQbUXR7dwe7WI7nShK/8O4zlOP C56rhnItr2uEJSYKPRUjukPvPiQ3HIlOQkZIcHgk7pQtv8x/frbI/qwW4BDxvdpXp8 b68mc4Jg5L5MT/i+8kCrgpggMF9WjfP+nf8O14CzmgZhCTip5IXnwPPEmB8jiU71N7 +iFP43i0H2bxXrxfmd0aE63lF/BrJ+CuWM2+cpW3VbpWYjPK/IYD7qVGz7PqkR7vJ7 +/LBT3GBNRFXQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qbLUv-009KQh-8k; Wed, 30 Aug 2023 14:44:41 +0100 Date: Wed, 30 Aug 2023 14:44:40 +0100 Message-ID: <86wmxcejav.wl-maz@kernel.org> From: Marc Zyngier To: Jiaxun Yang Cc: Krzysztof Kozlowski , Binbin Zhou , Binbin Zhou , Huacai Chen , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Huacai Chen , loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, diasyzhang@tencent.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: loongson,liointc: Fix warnings about liointc-2.0 In-Reply-To: References: <20230821061315.3416836-1-zhoubinbin@loongson.cn> <6ba31912-6738-6156-d5f4-3c8d3a3ca7bc@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jiaxun.yang@flygoat.com, krzysztof.kozlowski@linaro.org, zhoubb.aaron@gmail.com, zhoubinbin@loongson.cn, chenhuacai@loongson.cn, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, chenhuacai@kernel.org, loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, diasyzhang@tencent.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 30 Aug 2023 04:59:20 +0100, Jiaxun Yang wrote: >=20 >=20 >=20 > =E5=9C=A8 2023/8/25 20:56, Krzysztof Kozlowski =E5=86=99=E9=81=93: > [...] > > How did you sneak this property? The version - v2 - which was reviewed > > by Rob: > > https://lore.kernel.org/all/20190905144316.12527-7-jiaxun.yang@flygoat.= com/ > > did not have it. > >=20 > > Now v3 suddenly appears with Rob's review and this property: > > https://lore.kernel.org/all/20200112081416.722218-4-jiaxun.yang@flygoat= .com/ > >=20 > > Please help me understand this property appeared there and how did you > > get it reviewed? > Hi all, >=20 > It has been some years since this series was merged. > My vague memory tells me there was some off-list discussion made in IRC w= ith > linux-arch folks and IRQ folks to come up with this binding design. >=20 > In this case I guess I forgot to drop Rob's R-b tag when updating this pa= tch > between reversions. I=C2=A0 apologize for any inconvenience this may have= caused. >=20 > >=20 > >> <0xffffffff>, /* int1= */ > >> <0x00000000>, /* int2= */ > >> <0x00000000>; /* int3= */ > > So now you will keep bringing more hacks for a hacky property. No, this > > cannot go on. >=20 > What's the best way, in your opinion, to overhaul this property? As we do= n't > really care backward compatibility of DTBs on those systems we can > just redesign it. You may not care about backward compatibility, but I do. We don't break existing systems, full stop. As for the offending property, it has no place here either. DT is not the place where you put "performance knobs". M. --=20 Without deviation from the norm, progress is not possible.