From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EE9F1BC06B; Tue, 2 Jul 2024 16:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719939294; cv=none; b=WExlY9vdKTcWKUb4Xt9V0Bbs68jQRDb5ERs7olHopfmqdDmNBLRBj2z9lxA2FYysLsWOpiJrecIDnAObnwOjJfb9PcG35LOiGdVe9H4ht8gQR2sZ7sSL3xzxtx5XR9kL5siXSOTPdYvtlp4tZYjL3gDeOw0EvauVz3pn+wg6jIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719939294; c=relaxed/simple; bh=7cP9c/D+q/wwGCs5nQnAntLQJsixlKhlsJONo87tLoY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=pgYX5H0fjFU5PQ3vZ54ALb8vTHlYB6+oVOG5rqYWkfbvXmeJ1SsLvj+e0/O8HJronyw5ZBRPQlw2NYY2dteeGXh8nOFK/F3nffMt9MfN0fGgW/6rnhDzH5VnKMVDs9TiTrRJaMHwppW6XZLKQvuZlGoCScNsHfLiXUlRn1LV8VI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HNgkDJ8Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HNgkDJ8Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DC98C116B1; Tue, 2 Jul 2024 16:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719939294; bh=7cP9c/D+q/wwGCs5nQnAntLQJsixlKhlsJONo87tLoY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HNgkDJ8Q/P40NY9TZxmDmG4C9x5ZfwJNAio6ABrveLE4/VxBMWsk+7qsErG6I3vrs yWoswVVemNDliIVNA6OOW2JLYX/U+YVTORNFZb3yzKbTeHa9gA3JG9hk+U4tcNjJMY XL6Qf2PuZ7w6OJsprQrTxc8bz3tSZjkK1OpmP4UDLcVU3YwTACM3/ENnCAJGBU340J K+cfY9fOTRMZUOCJD9dLobZE8RXgJDRHUaHnki4DMFfk1M17DeWPgk0I8PEvG3YBn1 wg7dNbiesOY0SbNP6tageljV9oROiJny8oyIUPgNg8G6aDAe/lj0PNc4qk3NGIHEsP yjnvmE3t7n8FQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sOgmJ-009Ao2-My; Tue, 02 Jul 2024 17:54:51 +0100 Date: Tue, 02 Jul 2024 17:54:51 +0100 Message-ID: <86zfqzhgys.wl-maz@kernel.org> From: Marc Zyngier To: Christian Zigotzky Cc: Rob Herring , apatel@ventanamicro.com, DTML , Linux Kernel Mailing List , linuxppc-dev , mad skateman , "R.T.Dickinson" , Matthew Leaman , Darren Stevens , Christian Zigotzky Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 In-Reply-To: <3ab66fab-c3f2-4bed-a04d-a10c57dcdd9b@xenosoft.de> References: <3ab66fab-c3f2-4bed-a04d-a10c57dcdd9b@xenosoft.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: chzigotzky@xenosoft.de, robh@kernel.org, apatel@ventanamicro.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, madskateman@gmail.com, rtd2@xtra.co.nz, matthew@a-eon.biz, darren@stevens-zone.net, info@xenosoft.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 30 Jun 2024 11:21:55 +0100, Christian Zigotzky wrote: > > Hello, > > There is an issue with the identification of ATA drives with our > P.A. Semi Nemo boards [1] after the > commit "of/irq: Factor out parsing of interrupt-map parent > phandle+args from of_irq_parse_raw()" [2]. [snip] My earlier request for valuable debug information still stands. But while you're at it, can you please give the following hack a go? M. --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -282,8 +282,10 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) oldimap = imap; imap = of_irq_parse_imap_parent(oldimap, imaplen, out_irq); - if (!imap) - goto fail; + if (!imap) { + match = 0; + break; + } match &= of_device_is_available(out_irq->np); if (match) This may not be the final workaround even if it solves your boot problem, but will at least give us a hint at what is going wrong. I have the fuzzy feeling that we may be able to lob this broken system as part of the of_irq_imap_abusers[] array, which would solve things pretty "neatly". M. -- Without deviation from the norm, progress is not possible.