From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Tomas Novotny <tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Akinobu Mita
<akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Yong Li <sdliyong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/4] iio: dac: mcp4725: use regulator framework
Date: Fri, 14 Oct 2016 13:58:24 +0200 [thread overview]
Message-ID: <87088906-8986-cca0-c29a-747610bae982@metafoo.de> (raw)
In-Reply-To: <1476194263-12015-2-git-send-email-tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>
On 10/11/2016 03:57 PM, Tomas Novotny wrote:
Hi,
Looks mostly good. One small thing that should be addressed.
> diff --git a/include/linux/iio/dac/mcp4725.h b/include/linux/iio/dac/mcp4725.h
> index 91530e6..7c062e8 100644
> --- a/include/linux/iio/dac/mcp4725.h
> +++ b/include/linux/iio/dac/mcp4725.h
> @@ -10,7 +10,6 @@
> #define IIO_DAC_MCP4725_H_
>
> struct mcp4725_platform_data {
> - u16 vref_mv;
> };
Might as well remove the whole struct and file and drop the if (!pdata)
check in the driver probe function. Having to declare a empty platform_data
for the driver to work is not that sensible.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-14 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 13:57 [PATCH v2 0/4] iio: dac: mcp4725: use regulator framework, add vref and dt support Tomas Novotny
[not found] ` <1476194263-12015-1-git-send-email-tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>
2016-10-11 13:57 ` [PATCH v2 1/4] iio: dac: mcp4725: use regulator framework Tomas Novotny
[not found] ` <1476194263-12015-2-git-send-email-tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>
2016-10-14 11:58 ` Lars-Peter Clausen [this message]
[not found] ` <87088906-8986-cca0-c29a-747610bae982-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-10-14 12:06 ` Lars-Peter Clausen
2016-10-14 12:24 ` Tomas Novotny
2016-10-15 14:00 ` Jonathan Cameron
2016-10-11 13:57 ` [PATCH v2 2/4] iio: dac: mcp4725: support voltage reference selection Tomas Novotny
[not found] ` <1476194263-12015-3-git-send-email-tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>
2016-10-15 14:07 ` Jonathan Cameron
[not found] ` <e015de34-51bd-f43b-4a9f-cfe047d4fb3c-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-10-18 13:51 ` Tomas Novotny
2016-10-11 13:57 ` [PATCH v2 3/4] Documentation: dt: iio: add mcp4725/6 dac device binding Tomas Novotny
[not found] ` <1476194263-12015-4-git-send-email-tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>
2016-10-15 14:08 ` Jonathan Cameron
2016-10-18 12:43 ` Rob Herring
2016-10-11 13:57 ` [PATCH v2 4/4] iio: dac: mcp4725: add devicetree support Tomas Novotny
[not found] ` <1476194263-12015-5-git-send-email-tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org>
2016-10-15 14:14 ` Jonathan Cameron
[not found] ` <a710bc16-24e9-8b30-5db0-8eff371a012b-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-10-18 13:56 ` Tomas Novotny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87088906-8986-cca0-c29a-747610bae982@metafoo.de \
--to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
--cc=akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sdliyong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tomas-P46umIhNmdHrBKCeMvbIDA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).