From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 464F83DBD7C for ; Mon, 4 May 2026 13:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900260; cv=none; b=CxJSP0v1do7kW6ykQ+/AVa5a6ICJVBmtHGA9yKj0aS/ScMOtTdgx5uNj1Q/nrQIayu4mJp4Y2nVszc/F93P+rAsE6w6fepdghXF0qSrXjjafKGx8jNr/WSuu9Z/+EOORYGSQ4LUHFE2KoywK7j729psr7KjOsWbeWpn1HIbUx3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900260; c=relaxed/simple; bh=65BCyDO9jtqHt0rIS+TTWdrkvghKnA/Z0GBZ5zaHOzc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UDmZhImBiIxxBCYqTzX6hqub0/RBxhrctZITOBrHNSPkQoMxM1dAJv5yFEF48dAqqwKubNtsQ81gkKCOsz+1HXfV+WQogFkd+qtIUiYSqCfKawSfBc/hFfgCI4pP1qEUhDce/W6okFcCJgnzT58i9F/FrUUT6tvN48LV32EjkCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZSvuHGy9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XMhwT42B; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZSvuHGy9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XMhwT42B" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644B40UJ4160023 for ; Mon, 4 May 2026 13:10:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EyL+ckv32prGhdqPvBC96FXpnqbIVDmGry2rLJFtils=; b=ZSvuHGy95t9IhfsP U3AUnAAWUZb4mq54JFS6nvzoZ9btK6EbfUg23V7kI56xOv7GPGAzijdIcg4NtuwA QQzmGEQyU/M8acpw5M99WmnZoh9sOA+qPIXl0bAnsEezyx4ZT6VH1emP73U+So1v P7dUn0UWcIkTpQug6+gD66d4Umg7wTExv3+MGH+pzOShYIhqBy74moGYuJ7yqwDm qW8DAN2Nh0Yov6kGScLpG+Pb6VQHKwO1zbNqBJ1kq530dm4W+d0SNFH8E8kP9XW6 SVo8kV2gK42wvtxUL6SkLKEtx02NFmBDUEtCeGR1dxi/jjEP3YV433YmTCMgLyDY E780jA== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dw6yfe33j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 13:10:58 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-575287c467fso23746e0c.0 for ; Mon, 04 May 2026 06:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777900257; x=1778505057; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EyL+ckv32prGhdqPvBC96FXpnqbIVDmGry2rLJFtils=; b=XMhwT42BYOa/tG22c5TqncrG0WSs8tKCsN2doO/JXG8VgUpTHTnSgrdBFk4rSzfJ/s bSbWubMyxaZbQ/J1aoiXx+Ac8BUXJQwkv1O9+6QHcbm8tMzlWacj2HVy1O9TnwZxuJmC 0zOCXYIYB1doyquaS7YVyMsDrl3PEfskfNs5x3rvmmBlNiWQglWeS6irATSTgT8jPEbh DVw3Q++hjcJyuX5AmE8kmRG5blbynWQ1Lrz6Ul0sXjzDy3d3hBBIRdqYHZatQJzZxKyU DER3eEAiaCLU4s/vc9S6TYXaGRFiGud0IfsPCF9RxyAcUi9ZsUEbw/Gkmb6xLybr07lv DEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777900257; x=1778505057; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EyL+ckv32prGhdqPvBC96FXpnqbIVDmGry2rLJFtils=; b=APM1faEhf6kcrK8/SF6aWI16E5Mue3FEC346utaCNo5Sb2VhGd2jLtnXF5oQs1LsX/ hFsKyt7N0eTaU2c9Pg+IIXqT0cOvH1n9fJugjqU4Q+bav6fFmDQWe+p7fgiFk6FxpbFj nwrN4gh5Fsqg67CnrxRXa0pi7f9kZ1PkJXSgymRD8O89bkLkPyYfmc7N17YdzsDlv/e4 A7sfsBcjKbq8RY631jccfGSaVNGcgm3sjm5YsUn0NWg3zKfOfqWOqDKRLiJZNlDZJvBH DFl3KTSN+hUz8Z5ce0h9YKjzTdnHxpWyQVhZ6+xNuveRXjaAmAwnwDOiwOaF4U97m861 XNhQ== X-Forwarded-Encrypted: i=1; AFNElJ8GVJu4brI/1m5WBohNre8gxGpl6mDjOuzFXh0Hwp2ECHJmmQZGdbp8f4r772O6u5JJkat4041mBSWJ@vger.kernel.org X-Gm-Message-State: AOJu0YxXiTxe/lYFj8t65tuAFzPt9OcdrWCFbNKFjlAJ90J0TnNVQmdG laT8cvB+2tIQMRTZDJDkm25w8uvuyTekgSJ41pE4cbVle7v5xVAYTxT4CfrkgoGPNLVZWMw2Ibu 7ZdOq4WEHsWwD0viKBkd51rS9mPYrNdmwBQko18uj37V3y+9b7qOvx/LJHeWr/Mmo X-Gm-Gg: AeBDietzeedGWiAseixCGZUNxThbnYxFvkGl1aOGF5Uz7LmPfBCygaocL5G3TfMKdYl mDVs/nZlztkP6jAkDLGkSwCbGTfBPjNjuTg2Hsvy05dXXWKiEpykBjT1HUEvznzGQwfg21dCdup jfC/tInP5f6t3aqdowkqbsHp7/79ghLSiqIDgMk+yRAHt+HM9ly83Pj9a4/d/DcRvXiCH5oZPLF ZugEAxUqcsio07iIWksfFxZUBiQddpdVop+3lGVdcUyUZ8dYJhQQ2SjjmaS38emaPob1Y0D+H45 mdgVHrucBUmgKFYGA4HJrPJ8/seQiNpziGNnrKXUBZVmNtdMKN80HPuu7CmcksJVz2TPzVCfmnB FseggqL3jAFU9aEILMUenRzgS9cduzHK3/SaGxn7TX+lW0+qrYbTLzDuMLp8IDmDl7VeKV1NsfQ 4KInZump/dydPYbg== X-Received: by 2002:a05:6122:3611:b0:575:35f9:66b7 with SMTP id 71dfb90a1353d-57535f97091mr279803e0c.3.1777900257431; Mon, 04 May 2026 06:10:57 -0700 (PDT) X-Received: by 2002:a05:6122:3611:b0:575:35f9:66b7 with SMTP id 71dfb90a1353d-57535f97091mr279764e0c.3.1777900256820; Mon, 04 May 2026 06:10:56 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc1ad2d59fcsm149037266b.45.2026.05.04.06.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 06:10:55 -0700 (PDT) Message-ID: <870d16bb-b426-4285-a299-deb09ae90243@oss.qualcomm.com> Date: Mon, 4 May 2026 15:10:51 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: milos-fairphone-fp6: Enable WiFi To: Luca Weiss , Dmitry Baryshkov , Jeff Johnson , Baochen Qiang Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Koskovich , Liam Girdwood , Mark Brown , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Balakrishna Godavarthi , Rocky Liao , Johannes Berg , Jeff Johnson , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org References: <20260403-milos-fp6-bt-wifi-v2-0-393322b27c5f@fairphone.com> <20260403-milos-fp6-bt-wifi-v2-7-393322b27c5f@fairphone.com> <4fbs4arx6sez6fffy75ctmzecfvitr6aocau3cczlr2ps2ptld@v7wpa2irsihl> <2514523f-a43f-4470-a69b-3d5175d10385@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: dfP_TljMPZdlBhpoEdYSJjobv_38K-f6 X-Proofpoint-GUID: dfP_TljMPZdlBhpoEdYSJjobv_38K-f6 X-Authority-Analysis: v=2.4 cv=QY5WeMbv c=1 sm=1 tr=0 ts=69f89ae2 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=1iLxIbVeREuL6hqEqU8A:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDE0MCBTYWx0ZWRfX6EslVG4L0jzm toa0a82PZtvM16ShyPQzBoU1tzGDaQc+IpNIrRT6BX/l8SxktK60sfhGfKSJraR/gvDibbeinT7 V4fjONgRTaWdssTcywU1QQWmEOKVUr6X0ga6I3YZb6NfBhYgXb+XmawgF4VQu0XF+F3LjxArFbb b1rqgbM3LGm++OFE7yeflPmix6O3F2oyEVBJBpQw7SjmVe9a9a5+ABIcrOiLCTTUV2nAommLWdg czFxh+SxNxpKSHL6/llLAUid5lFZ2JgdQXD0COwlWvkHpg3xVbhaKwqkrxqsGoFpFePLWNIgBO7 0d8ei8EoJEDb0nYRvmngrl8h+lnGJgUd2JFG18vMRck0uVNQo/J5IDh1L407Ad67JCq1K+waVuN OPJ9qOKSXlkTot1UgLQ62Z19MJChBY+FoSJNtc+e4IRRS0RXvPyCrvZnkW0no8VgZfsucW0NeeI /NAPSqMlm/vAIkpETTw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_04,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040140 On 5/1/26 11:20 AM, Luca Weiss wrote: > Hi Konrad, > > On Tue Apr 7, 2026 at 3:16 PM CEST, Konrad Dybcio wrote: >> On 4/3/26 9:35 PM, Dmitry Baryshkov wrote: >>> On Fri, Apr 03, 2026 at 03:52:53PM +0200, Luca Weiss wrote: >>>> Configure and enable the WiFi node, and add the required pinctrl to >>>> provide the sleep clock from the PMK8550 (PMK7635) to WCN6755. >>>> >>>> Thanks to Alexander Koskovich for helping with the bringup, adding >>>> the missing pinctrl to make the WPSS stop crashing. >>>> >>>> Link: https://lore.kernel.org/linux-arm-msm/DBF7OWAWQ94M.FSCP4DPF8ZJY@fairphone.com/ >>>> Reviewed-by: Dmitry Baryshkov >>>> Signed-off-by: Luca Weiss >>>> --- >>>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 19 ++++++++++++++++++- >>>> 1 file changed, 18 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> index db72418b7195..d8ac495ca7c8 100644 >>>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>> @@ -242,7 +242,7 @@ wcn6750-pmu { >>>> >>>> clocks = <&rpmhcc RPMH_RF_CLK1>; >>>> >>>> - pinctrl-0 = <&bluetooth_enable_default>; >>>> + pinctrl-0 = <&bluetooth_enable_default>, <&pmk8550_sleep_clk_default>; >>>> pinctrl-names = "default"; >>>> >>>> regulators { >>>> @@ -766,6 +766,17 @@ &pmiv0104_eusb2_repeater { >>>> qcom,tune-usb2-preem = /bits/ 8 <0x6>; >>>> }; >>>> >>>> +&pmk8550_gpios { >>>> + pmk8550_sleep_clk_default: sleep-clk-default-state { >>>> + pins = "gpio5"; >>>> + function = "func1"; >>>> + input-disable; >>>> + output-enable; >>> >>> Hmm, if it's a sleep_clk, should it not be handled via the power >>> sequencer? >> >> If you mean that it may be needed to toggle it with specific timings, >> possibly.. seems that WCN6855 has a "xo-clk" GPIO defined. I requested >> access to some docs that I think should have the answer, hopefully should >> get it soon. > > Did you manage to get anything there yet? Yeah, sorry, it got lost in the sea of emails.. The PDF talks about the electrical requirements of the clock signal and the section titled "Power-up sequence timing" doesn't mention it at all, so my assumption would be "OK so long as it's ticking before you power up the WCN" Konrad