From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EECC61DA4 for ; Fri, 3 Feb 2023 07:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232470AbjBCHJz (ORCPT ); Fri, 3 Feb 2023 02:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbjBCHJq (ORCPT ); Fri, 3 Feb 2023 02:09:46 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F8D68AE2 for ; Thu, 2 Feb 2023 23:09:32 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id h16so3758298wrz.12 for ; Thu, 02 Feb 2023 23:09:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=91H7aAbtElqTaptJ9Vb0dyS9FKfuyA5IbH1LTzOZk1w=; b=kxIW9UUpSvaia8/H81GLavJ4mQWTC9NVIF/UM8mTgquarXVcOYW223Tp1ZbgavI1u7 2OCqXuAkDBtFRPciI5sntZWnwYqZEjZzskVKWufTIDy7NQNMgH0pg4MV8gAHiHtY9VR3 0hcBk2FtFixn+Ot9diJncYJwYaKiytsJiCtQwf6CgqZ06g1fXS+SlbtLcGyRyt5gcHRA hpzfB3KH3SfxhQth5axvjIiwVLi1AmSiljimg8k/I84mFBVytz1RSqGvqTLcVC6tL6D/ sqElxkSTdl5eV/XCsViXTGPTK5YR18lY7c5xvF3BF/eWlofQ9DuvgmoT7LYI+Gmg/j3I 7K+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=91H7aAbtElqTaptJ9Vb0dyS9FKfuyA5IbH1LTzOZk1w=; b=4Xm3ia5F8DlXaLcdUGy5lm1gUX09sQ1hXKAGPqXZGesbtrcDh7rs1zJIAxkp6H8MXJ 1a53vlY/tZkr4nsgcfBAx2hKTPzLt1VWUk21rwZTqnA8wAzkHwqJnmhhCKWfvZIjHrlc 1d4IopGq4zztyB1mTEBpKfMPSV5WNIVdL9cfK+eHYRuPmSqk1HhLxuiEJBSFezeisFZI /uV8YF5XG6Ac0Til3kE0vmNGNB5N+nQ9NyUgVU053GRqNdlwBsY0pR9SVsvTCqm1ozjd aR9asmZPELekAQhp1hu0yx6JEHm9Ct0IuAFk8Q1YgFQyYZaSUyBaPvPG1Zl9Rebam4L0 m0Aw== X-Gm-Message-State: AO0yUKWM2t3jZ9LnJX9UKT386cKFvD2Zm+o0uFReUqyxK4WPp7zdjhYv 8StSH6x9vAKLSxde4RZ2FOgXdQ== X-Google-Smtp-Source: AK7set8TwQRjsPo9v5JN/ENZh1nluMWyKJJlKIkzIlbEhiGRce7jfa72hOsMKBiovU00TszO03eK6g== X-Received: by 2002:a05:6000:184a:b0:2bf:d2fe:8647 with SMTP id c10-20020a056000184a00b002bfd2fe8647mr11234697wri.70.1675408170631; Thu, 02 Feb 2023 23:09:30 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f9-20020a5d4dc9000000b002bfb37497a8sm1245058wru.31.2023.02.02.23.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 23:09:30 -0800 (PST) Message-ID: <870f6ec5-5378-760b-7a30-324ee2d178cf@linaro.org> Date: Fri, 3 Feb 2023 08:09:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Content-Language: en-US To: yanhong wang , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20230118061701.30047-1-yanhong.wang@starfivetech.com> <20230118061701.30047-7-yanhong.wang@starfivetech.com> <55f020de-6058-67d2-ea68-6006186daee3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/02/2023 04:14, yanhong wang wrote: > > > On 2023/1/18 23:51, Krzysztof Kozlowski wrote: >> On 18/01/2023 07:17, Yanhong Wang wrote: >>> Add JH7110 ethernet device node to support gmac driver for the JH7110 >>> RISC-V SoC. >>> >>> Signed-off-by: Yanhong Wang >>> --- >>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 93 ++++++++++++++++++++++++ >>> 1 file changed, 93 insertions(+) >>> >>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >>> index c22e8f1d2640..c6de6e3b1a25 100644 >>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >>> @@ -433,5 +433,98 @@ >>> reg-shift = <2>; >>> status = "disabled"; >>> }; >>> + >>> + stmmac_axi_setup: stmmac-axi-config { >> >> Why your bindings example is different? >> > > There are two gmacs on the StarFive VF2 board, and the two > gmacs use the same configuration on axi, so the > stmmac_axi_setup is independent, which is different > from the bindings example. > > >> Were the bindings tested? Ahh, no they were not... Can you send only >> tested patches? >> >> Was this tested? >> > Yes, the bindings have been tested on the StarFive VF2 board and work normally. Then please tell me how did you test the bindings on the board? How is it even possible and how the board is related to bindings? As you could easily see from Rob's reply they fail, so I have doubts that they were tested. If you still claim they were - please paste the output from testing command. Best regards, Krzysztof