Re: [PATCH v8 9/9] iio: accel: mma8452: Support interrupt sharing

[Esben Haabendal <esben@geanix.com>]

"Esben Haabendal" <esben@geanix.com> writes:
> <sashiko-bot@kernel.org> writes:
>>> +
>>> +	ret = mma8452_standby(data);
>>> +	if (ret < 0) {
>>> +		dev_err(dev, "transition to STANDBY mode failed\n");
>>> +		ret = -EAGAIN;
>>> +		goto out_restore_ctrl_reg4;
>>>  	}
>>
>> [Severity: Low]
>> Does this mix goto-based error handling with guard() cleanup in the same
>> function?
>>
>> The cleanup subsystem guidelines state that mixing goto and scope-based cleanup
>> creates confusing ownership semantics.
>>
>> [ ... ]
>
> I will try to convert to scope-based cleanup to avoid this, and see if I
> can create something nice with that approach.

I hope it is okay that I delay doing this for the next series, where I
will introduce scope-based cleanup for runtime PM also.

While it is best not to mix goto and scope-based cleanup in the same
functions, in this particular case, it is working as expected for now.
The only scope-based cleanup is the guard which is first in the
function, and is supposed to be run after all the goto-based error
handling, which is exactly what will happen.

But I will try and rework it to use scope-based cleanup only as part of
the next series also.

/Esben