From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEABF16D339; Fri, 5 Apr 2024 12:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712318494; cv=none; b=Ji1vbbMFVbMJuGYr56xLaxuIWGEWXLjdDeYKZ/E1toowTIfCTT28UPvsTih85w9ceryGTHm0kB40F6GCmcI5FgAi/fNJzitB1E3+XkoYxJHPdU4TIVZVzA92GU/Aggt/My+dgek9dAbjDXElLKfGIwnCQGPl0Jf8P2ea0/bbWGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712318494; c=relaxed/simple; bh=QfTxdUZ4pDgKliLEER39neqecZfbyAbJ7BTYOdpacGc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=XNX6yxuS77qkW3uYgiVEb7RyhpRUZHXgSxQid6av6TRk7rYTErOTD0a0HgDII22uLqn110Ye6UQOg8z7JwuYTd66qTJxGVKNYEYfzkVewtTJdRp48/8nlqqT14sDD6Wq6xBbSHIgqHgbFS93xUTkn9o0IZHThvgqh+6TiwAd26I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iyyFBcSD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iyyFBcSD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDA8EC433F1; Fri, 5 Apr 2024 12:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712318494; bh=QfTxdUZ4pDgKliLEER39neqecZfbyAbJ7BTYOdpacGc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iyyFBcSD6m7ogc+YN8nQm4I7X3V3LJ3Z8Cj1jZfPA5pcFRZ0S7cHwyHl5oHubDP2y gj8TOTmSmxmEx9q9ssDnP0jeX09zetYRhWKXCU+do2APq3xH0ixAXuLRLikKdiU+LN 39dPXYDdmNIPp5obkXwG1FQoxasd+NDdzRI2gV51KhnaOU/vB8DPlvIpGy68k8BTss cnYS+SOZs1p9pMvexdOeFsKjyBBygHNTv1fwnTov7lmQDSHoZOAA+1Z2HIoUyNrtUN FJZJWplHpSGGy8loofeW64+QAkKfqGue72ECVf7Z/128+ViA2LHUTI/QkH9FAx3ZkR 15ndyIAvKOj5A== From: Kalle Valo To: Dmitry Baryshkov Cc: Jeff Johnson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides References: <20240306-wcn3990-firmware-path-v2-0-f89e98e71a57@linaro.org> <87plw7hgt4.fsf@kernel.org> <87cys7hard.fsf@kernel.org> <87v85wg39y.fsf@kernel.org> Date: Fri, 05 Apr 2024 15:01:29 +0300 In-Reply-To: (Dmitry Baryshkov's message of "Sat, 9 Mar 2024 17:07:46 +0200") Message-ID: <871q7k3tnq.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Baryshkov writes: > On Fri, 8 Mar 2024 at 17:19, Kalle Valo wrote: >> >> Dmitry Baryshkov writes: >> >> >> To be on the safe side using 'qcom-rb1' makes sense but on the other >> >> hand that means we need to update linux-firmware (basically add a new >> >> symlink) everytime a new product is added. But are there going to be >> >> that many new ath10k based products? >> >> >> >> Using 'qcm2290' is easier because for a new product then there only >> >> needs to be a change in DTS and no need to change anything >> >> linux-firmware. But here the risk is that if there's actually two >> >> different ath10k firmware branches for 'qcm2290'. If that ever happens >> >> (I hope not) I guess we could solve that by adding new 'qcm2290-foo' >> >> directory? >> >> >> >> But I don't really know, thoughts? >> > >> > After some thought, I'd suggest to follow approach taken by the rest >> > of qcom firmware: >> >> Can you provide pointers to those cases? > > https://gitlab.com/kernel-firmware/linux-firmware/-/tree/main/qcom/sc8280xp/LENOVO/21BX > >> >> > put a default (accepted by non-secured hardware) firmware to SoC dir >> > and then put a vendor-specific firmware into subdir. If any of such >> > vendors appear, we might even implement structural fallback: first >> > look into sdm845/Google/blueline, then in sdm845/Google, sdm845/ and >> > finally just under hw1.0. >> >> Honestly that looks quite compilicated compared to having just one >> sub-directory. How will ath10k find the directory names (or I vendor and >> model names) like 'Google' or 'blueline' in this example? > > I was thinking about the firmware-name = "sdm845/Google/blueline". But > this can be really simpler, firmware-name = "blueline" or > "sdm845/blueline" with no need for fallbacks. I have been also thinking about this and I would prefer not to have the fallbacks. But good if you agree with that. IMHO just "sdm845-blueline" would be the most simple. I don't see the point of having a directory structure when there are not that many directories really. But this is just cosmetics. > My point is that the firmware-name provides the possibility to handle > that in different ways. Very good, thanks. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches