From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Shenghao Ding <13916275206@139.com>,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com,
shenghao-ding@ti.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, x1077012@ti.com, peeyush@ti.com,
navada@ti.com, gentuser@gmail.com, Ryan_Chu@wistron.com,
Sam_Wu@wistron.com
Subject: Re: [PATCH v4 5/6] ALSA: hda/tas2781: Add tas2781 HDA driver
Date: Tue, 06 Jun 2023 18:12:43 +0200 [thread overview]
Message-ID: <871qiofu2s.wl-tiwai@suse.de> (raw)
In-Reply-To: <65ef4914-dc0e-4f0f-a6f8-3016931488bd@sirena.org.uk>
On Tue, 06 Jun 2023 18:10:13 +0200,
Mark Brown wrote:
>
> On Tue, Jun 06, 2023 at 06:08:51PM +0200, Takashi Iwai wrote:
> > Shenghao Ding wrote:
>
> > > + //Lenovo devices
> > > + if ((subid == 0x387d) || (subid == 0x387e) || (subid == 0x3881)
> > > + || (subid == 0x3884) || (subid == 0x3886) || (subid == 0x38a7)
> > > + || (subid == 0x38a8) || (subid == 0x38ba) || (subid == 0x38bb)
> > > + || (subid == 0x38be) || (subid == 0x38bf) || (subid == 0x38c3)
> > > + || (subid == 0x38cb) || (subid == 0x38cd))
> > > + tas_priv->catlog_id = LENOVO;
> > > + else
> > > + tas_priv->catlog_id = OTHERS;
>
> > Hmm, I don't like checking subid here, but we can live with it for
> > now...
>
> Might be more idiomatically/neatly written as a switch statement though.
Yes, it'll make it easier to add a new entry, too.
thanks,
Takashi
prev parent reply other threads:[~2023-06-06 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 22:36 [PATCH v4 5/6] ALSA: hda/tas2781: Add tas2781 HDA driver Shenghao Ding
2023-05-28 7:54 ` Christophe JAILLET
2023-06-06 16:08 ` Takashi Iwai
2023-06-06 16:10 ` Mark Brown
2023-06-06 16:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qiofu2s.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13916275206@139.com \
--cc=Ryan_Chu@wistron.com \
--cc=Sam_Wu@wistron.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gentuser@gmail.com \
--cc=kevin-lu@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=x1077012@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).