From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1419C54EE9 for ; Tue, 13 Sep 2022 18:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232521AbiIMS06 (ORCPT ); Tue, 13 Sep 2022 14:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231797AbiIMS0j (ORCPT ); Tue, 13 Sep 2022 14:26:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B62B7DF24; Tue, 13 Sep 2022 10:44:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 63E21B81095; Tue, 13 Sep 2022 17:44:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06FC1C433D6; Tue, 13 Sep 2022 17:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663091079; bh=hvvNtLef5JyDw6JZ44jNYYoGvekWe6nVJNHmLeq2uJE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fWaR1m7xBq1XesUNbibQzGM/xCuS7x6kez+gaPbU2sNuoLF5eW+3uodpOyNimt8BC a6DWFDcszVOk57rDu+zx6uI5PF9aDJGjlSZSNrh3hdgMSK4j8RzWSf1m96TFYNhThe kdUox2mo/VMSAlvQBhnxhXAqO1By0iTwyX8HrfFKt69z2+WaId8LSzcQjEOZgrlCuo sRLMXgHX4QjznlvfOZsIAP8Q/LwwHymoBGXNg/G0Or9J2h+2wyUExx+QgMLgpP6Dc3 uthhf/6PeJ0OvcQnTKMD+cRSF3Q2008eCzG21K2eqAvvceeHKyce1eNb0eSY3QvN0Z DFvVIefdMIM3g== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oY9xc-00A1nz-SG; Tue, 13 Sep 2022 18:44:36 +0100 Date: Tue, 13 Sep 2022 18:44:36 +0100 Message-ID: <871qsfuq2j.wl-maz@kernel.org> From: Marc Zyngier To: Frank Li Cc: "tglx@linutronix.de" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kw@linux.com" , "bhelgaas@google.com" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , Peng Fan , Aisheng Dong , "jdmason@kudzu.us" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "kishon@ti.com" , "lorenzo.pieralisi@arm.com" , "ntb@lists.linux.dev" , "lznuaa@gmail.com" , "imx@lists.linux.dev" , "manivannan.sadhasivam@linaro.org" Subject: Re: [EXT] Re: [PATCH v9 2/4] irqchip: Add IMX MU MSI controller driver In-Reply-To: References: <20220907034856.3101570-1-Frank.Li@nxp.com> <20220907034856.3101570-3-Frank.Li@nxp.com> <87fsh2qpq4.wl-maz@kernel.org> <877d2dvs0d.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: frank.li@nxp.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com, imx@lists.linux.dev, manivannan.sadhasivam@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 12 Sep 2022 16:53:40 +0100, Frank Li wrote: > > > > [Frank Li] I remember you said that irq-chip can't be removed. > > > So I am not sure why need build as module. > > > > Not being removed doesn't mean it cannot be built as a module and > > loaded on demand. Why should I be forced to have this driver built-in > > if my kernel is used on a variety of systems, only one of them having > > this device? > > [Frank Li] A problem, platform_msi_create_irq_domain have NOT export > to let module Call it. > https://elixir.bootlin.com/linux/latest/source/drivers/base/platform-msi.c#L122 > > Do you want to me add EXPORT_SYMBOL_GPL for it OR keep "bool" here? Please add a patch exporting the missing symbols, and make the think modular. M. -- Without deviation from the norm, progress is not possible.