From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C76C43603 for ; Thu, 19 Dec 2019 13:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67704222C2 for ; Thu, 19 Dec 2019 13:49:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qgBErW+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbfLSNtq (ORCPT ); Thu, 19 Dec 2019 08:49:46 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:22549 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726834AbfLSNtp (ORCPT ); Thu, 19 Dec 2019 08:49:45 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576763385; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=9RnoUeGfktZIeoc4N0o7RN8cowShMV+lAkk7GEI3L6Q=; b=qgBErW+Io1UFT06mWcQ8l7ZaeIWmGTucoweMBFPvhBxWU4Ri+U3KNxTBy/LArNgJqnrSLHDb aFABlW9hm/n5iR+kdlHRPWrKIFd2RrmwRbhHn0gOtQebr7XajdzPR8zD/WVCl5zSa17yC0vL YY1tcE8xg525diXEneLg8GbW2do= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5dfb7ff7.7f7ef0e35a08-smtp-out-n01; Thu, 19 Dec 2019 13:49:43 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B1FBFC447B6; Thu, 19 Dec 2019 13:49:43 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E098DC447A6; Thu, 19 Dec 2019 13:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E098DC447A6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: John Crispin Cc: Rob Herring , devicetree@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH 1/2] dt: bindings: net: ath11k: add qcom,board_id definition References: <20191217164329.4151-1-john@phrozen.org> Date: Thu, 19 Dec 2019 15:49:39 +0200 In-Reply-To: <20191217164329.4151-1-john@phrozen.org> (John Crispin's message of "Tue, 17 Dec 2019 17:43:28 +0100") Message-ID: <871rt077d8.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org John Crispin writes: > We need to be able to define what id the board has allowing us to load the > correct definition data. This patch adds the description of the required > property. > > Signed-off-by: John Crispin > --- > .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > index a1717db36dba..c68daf6ad424 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > @@ -142,6 +142,11 @@ properties: > * reg > * reg-names > > + qcom,board_id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The board id defining what board definition should be loaded I think this needs more discussion. This is very tricky to get right, as it needs to be extensible and what not. With ath10k we have learned that a simple integer is not enough. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches