From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=57PP=TP=renesas.com=kuninori.morimoto.gx@kernel.org>
Date: 15 May 2019 17:26:07 +0900
Message-ID: <871s106ssi.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v3 11/15] usb: renesas_usbhs: Add support for RZ/A2
In-Reply-To: <20190514145605.19112-12-chris.brandt@renesas.com>
References: <20190514145605.19112-1-chris.brandt@renesas.com>
	<20190514145605.19112-12-chris.brandt@renesas.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Simon Horman <horms@verge.net.au>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
List-ID: <devicetree@vger.kernel.org>


Hi Chris

> +static int usbhs_rza2_hardware_exit(struct platform_device *pdev)
> +{
> +	struct usbhs_priv *priv = usbhs_pdev_to_priv(pdev);
> +
> +	if (priv->phy) {
> +		phy_put(priv->phy);
> +		priv->phy = NULL;
> +	}
> +
> +	return 0;
> +}

phy_put() will do nothing if priv->phy was NULL.
We can remove if() here ?

Thank you for your help !!
Best regards
---
Kuninori Morimoto