From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FF353803FD; Mon, 1 Jun 2026 06:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780297139; cv=none; b=Za0EHo+FrwehQ/3QQirsK7q7GHw/fUTDumYdj2PTOKgTLDTMngepug7LSSeqXjqEcUnch1/n9allF7Q/SqfRDDK/zqaiAn+I6d9PcLE12Upwxt6EwaR6y3+T6ZsZP9TVLFuCCHlNbEo0JVYjwrTyPt+03KCIY90Bvhs8o83A7S0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780297139; c=relaxed/simple; bh=WBKKuhdxx/bAE1oVCnOlclgROzjpYuF6S3zJuCPlCuI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Z8GS3397/8dq60YuAUuPPJdUNDCHY2c4e2iS0gHBkkCuKkkzl5PWwkC3c82ddKS2HQdpdxEvimTY74BjgMLfs7KARxby7SKVRuDKDg0V4EuNDIMCDH0JvsnSekZbMdMxWESJHkNNj6gGQAO4JEo8/ts6mVmrdDh+QYoEUsbhIeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HQBfHFbh; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HQBfHFbh" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 6FAF4C6247C; Mon, 1 Jun 2026 06:58:57 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7D9CC602AB; Mon, 1 Jun 2026 06:58:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 10E1110888CCD; Mon, 1 Jun 2026 08:58:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780297133; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=mIIouX9atwC8TO7vo2wcLgAJzq/cTaHoTN8DO5/T+0Q=; b=HQBfHFbhqkjsF4pCV3oiBNQaeiPV0l/QdDp1DfBvD4+AlikHlQ0c1ENujAD7kqhbiXt15J KM0NSuc3onfrGwhRq2qpaIY1OCeASQkJMl29QvQ8eJLCab4THNCEzm9I78Hs4LTONYY9Ai 440QtMOWoPVqQ7wOxY5TW0MIO+2RJ0NmUXhVKy8JSl17UmJGfWwmWx8VenwiCp5ESB915T 6Rysm7UilOxHXF38ffSIzePeikeaqumzH5jT2U2FEwVDiPuy99pq4ACd5uSHFsHDPC1b/7 C+jZQgL9Ry69ECOdwhNnAXHZIbJdVe8aeVsQiq6SlMDaNusrvR1gdQtmw7A4mA== From: Gregory CLEMENT To: Jun Yan , linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Baruch Siach , Shawn Guo , Paul Barker , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Wei Xu , Geert Uytterhoeven , Patrice Chotard , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 shutdown GPIO polarity In-Reply-To: <20260525144629.498630-7-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> <20260525144629.498630-7-jerrysteve1101@gmail.com> Date: Mon, 01 Jun 2026 08:58:43 +0200 Message-ID: <8733z621cs.fsf@BLaptop.bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello, > The is31fl3199 shutdown pin is active-low [1]. Correct the GPIO flags > from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. > > [1] https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf > > Fixes: 737929191283 ("arm64: dts: marvell: add Globalscale MOCHAbin") > Signed-off-by: Jun Yan What happens if this patch is merged before the driver LED patch? Will it break something? Gregory > --- > arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/= arm64/boot/dts/marvell/armada-7040-mochabin.dts > index 6bdc4f1e6939..cf690a85cc2a 100644 > --- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts > @@ -236,7 +236,7 @@ leds@64 { > #size-cells =3D <0>; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&is31_sdb_pins>; > - shutdown-gpios =3D <&cp0_gpio1 30 GPIO_ACTIVE_HIGH>; > + shutdown-gpios =3D <&cp0_gpio1 30 GPIO_ACTIVE_LOW>; > reg =3D <0x64>; >=20=20 > led1_red: led@1 { > --=20 > 2.54.0 > --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com