From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Tomasz Maciej Nowak <tmn505@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version
Date: Fri, 13 Mar 2020 21:32:38 +0100 [thread overview]
Message-ID: <8736acyp09.fsf@FE-laptop> (raw)
In-Reply-To: <20200227164842.11116-1-tmn505@gmail.com>
Hi Tomasz,
> The commit introducing ESPRESSObin variants didn't specify dts version,
> and because of that they are treated by dtc as legacy ones. Fix that by
> properly specifying version in each dts.
>
> Fixes: 447b878935 ("arm64: dts: marvell: add ESPRESSObin variants")
> Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts | 2 ++
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 ++
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts | 2 ++
> arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
> 4 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
> index bd9ed9dc9c3e..ec72a11ed80f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts
> @@ -11,6 +11,8 @@
> * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
> */
>
> +/dts-v1/;
> +
> #include "armada-3720-espressobin.dtsi"
>
> / {
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 6e876a6d9532..03733fd92732 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -11,6 +11,8 @@
> * Schematic available at http://wiki.espressobin.net/tiki-download_file.php?fileId=200
> */
>
> +/dts-v1/;
> +
> #include "armada-3720-espressobin.dtsi"
>
> / {
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index 0f8405d085fd..8570c5f47d7d 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -11,6 +11,8 @@
> * Schematic available at http://wiki.espressobin.net/tiki-download_file.php?fileId=200
> */
>
> +/dts-v1/;
> +
> #include "armada-3720-espressobin.dtsi"
>
> / {
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 53b8ac55a7f3..c8e2e993c69c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -7,8 +7,6 @@
> *
> */
>
> -/dts-v1/;
> -
> #include <dt-bindings/gpio/gpio.h>
> #include "armada-372x.dtsi"
>
> --
> 2.25.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2020-03-13 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 16:48 [PATCH 1/2] arm64: dts: marvell: espressobin: indicate dts version Tomasz Maciej Nowak
2020-02-27 16:48 ` [PATCH 2/2] arm64: dts: marvell: build ESPRESSObin variants Tomasz Maciej Nowak
2020-03-13 20:32 ` Gregory CLEMENT
2020-03-13 20:32 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736acyp09.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).