From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v3] arm64: dts: marvell: Add device tree for uDPU board Date: Tue, 15 Jan 2019 17:37:36 +0100 Message-ID: <8736ptri5r.fsf@FE-laptop> References: <20190111172055.30451-1-vladimir.vid@sartura.hr> <20190115144421.29968-1-vladimir.vid@sartura.hr> <20190115161608.GA25888@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190115161608.GA25888@lunn.ch> (Andrew Lunn's message of "Tue, 15 Jan 2019 17:16:08 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Lunn Cc: devicetree@vger.kernel.org, Luis Torres , Paul Arola , Luka Perkov , Vladimir Vid , Scott Roberts , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Andrew, On mar., janv. 15 2019, Andrew Lunn wrote: > Hi Vladimir > > Ah, i did not notice early. You need to Cc: the Marvell mvebu > maintainers. They are the ones who will accept this patch. > > >> + leds { >> + pinctrl-names = "default"; >> + compatible = "gpio-leds"; >> + >> + power@487 { >> + label = "power:green:led1"; >> + gpios = <&gpionb 11 GPIO_ACTIVE_LOW>; >> + default-state = "off"; >> + }; > > I'm a bit out of date with dtc warnings. I think the @487 will > generate a warning because there is no reg property? > > Gregory, do you know? I confirm that if there is no reg then there should not have a @XXX. Gregory > > Thanks > Andrew > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com