* [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required [not found] <20231111215647.4966-1-luizluca@gmail.com> @ 2023-11-11 21:51 ` Luiz Angelo Daros de Luca 2023-11-12 7:37 ` Krzysztof Kozlowski ` (2 more replies) 2023-11-11 21:51 ` [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller Luiz Angelo Daros de Luca 1 sibling, 3 replies; 9+ messages in thread From: Luiz Angelo Daros de Luca @ 2023-11-11 21:51 UTC (permalink / raw) To: netdev Cc: linus.walleij, alsi, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, pabeni, robh+dt, krzk+dt, arinc.unal, Luiz Angelo Daros de Luca, devicetree, Rob Herring The 'reset-gpios' should not be mandatory. although they might be required for some devices if the switch reset was left asserted by a previous driver, such as the bootloader. Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Cc: devicetree@vger.kernel.org Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/net/dsa/realtek.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml index cce692f57b08..46e113df77c8 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml @@ -127,7 +127,6 @@ else: - mdc-gpios - mdio-gpios - mdio - - reset-gpios required: - compatible -- 2.42.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required 2023-11-11 21:51 ` [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required Luiz Angelo Daros de Luca @ 2023-11-12 7:37 ` Krzysztof Kozlowski 2023-11-13 20:30 ` Luiz Angelo Daros de Luca 2023-11-13 8:31 ` Linus Walleij 2023-11-14 12:23 ` Alvin Šipraga 2 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-11-12 7:37 UTC (permalink / raw) To: Luiz Angelo Daros de Luca, netdev Cc: linus.walleij, alsi, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, pabeni, robh+dt, krzk+dt, arinc.unal, devicetree, Rob Herring On 11/11/2023 22:51, Luiz Angelo Daros de Luca wrote: > The 'reset-gpios' should not be mandatory. although they might be > required for some devices if the switch reset was left asserted by a > previous driver, such as the bootloader. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Rob Herring <robh@kernel.org> If this is first RFC, how did you get the Acks? If this is not v1, provide changelog. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required 2023-11-12 7:37 ` Krzysztof Kozlowski @ 2023-11-13 20:30 ` Luiz Angelo Daros de Luca 0 siblings, 0 replies; 9+ messages in thread From: Luiz Angelo Daros de Luca @ 2023-11-13 20:30 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: netdev, linus.walleij, alsi, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, pabeni, robh+dt, krzk+dt, arinc.unal, devicetree, Rob Herring > On 11/11/2023 22:51, Luiz Angelo Daros de Luca wrote: > > The 'reset-gpios' should not be mandatory. although they might be > > required for some devices if the switch reset was left asserted by a > > previous driver, such as the bootloader. > > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Cc: devicetree@vger.kernel.org > > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > Acked-by: Rob Herring <robh@kernel.org> > > If this is first RFC, how did you get the Acks? If this is not v1, > provide changelog. Sorry Krzysztof, I might not have handled it correctly. Let me try to fix that. This RFC is based on a v1/v2 series that morphed into this one. https://lists.openwall.net/netdev/2023/10/24/348 https://lists.openwall.net/netdev/2023/10/27/257 > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required 2023-11-11 21:51 ` [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required Luiz Angelo Daros de Luca 2023-11-12 7:37 ` Krzysztof Kozlowski @ 2023-11-13 8:31 ` Linus Walleij 2023-11-14 12:23 ` Alvin Šipraga 2 siblings, 0 replies; 9+ messages in thread From: Linus Walleij @ 2023-11-13 8:31 UTC (permalink / raw) To: Luiz Angelo Daros de Luca Cc: netdev, alsi, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, pabeni, robh+dt, krzk+dt, arinc.unal, devicetree, Rob Herring On Sat, Nov 11, 2023 at 10:57 PM Luiz Angelo Daros de Luca <luizluca@gmail.com> wrote: > The 'reset-gpios' should not be mandatory. although they might be > required for some devices if the switch reset was left asserted by a > previous driver, such as the bootloader. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required 2023-11-11 21:51 ` [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required Luiz Angelo Daros de Luca 2023-11-12 7:37 ` Krzysztof Kozlowski 2023-11-13 8:31 ` Linus Walleij @ 2023-11-14 12:23 ` Alvin Šipraga 2 siblings, 0 replies; 9+ messages in thread From: Alvin Šipraga @ 2023-11-14 12:23 UTC (permalink / raw) To: Luiz Angelo Daros de Luca Cc: netdev@vger.kernel.org, linus.walleij@linaro.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzk+dt@kernel.org, arinc.unal@arinc9.com, devicetree@vger.kernel.org, Rob Herring On Sat, Nov 11, 2023 at 06:51:04PM -0300, Luiz Angelo Daros de Luca wrote: > The 'reset-gpios' should not be mandatory. although they might be > required for some devices if the switch reset was left asserted by a > previous driver, such as the bootloader. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > --- > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > index cce692f57b08..46e113df77c8 100644 > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > @@ -127,7 +127,6 @@ else: > - mdc-gpios > - mdio-gpios > - mdio > - - reset-gpios > > required: > - compatible > -- > 2.42.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller [not found] <20231111215647.4966-1-luizluca@gmail.com> 2023-11-11 21:51 ` [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required Luiz Angelo Daros de Luca @ 2023-11-11 21:51 ` Luiz Angelo Daros de Luca 2023-11-13 8:31 ` Linus Walleij ` (2 more replies) 1 sibling, 3 replies; 9+ messages in thread From: Luiz Angelo Daros de Luca @ 2023-11-11 21:51 UTC (permalink / raw) To: netdev Cc: linus.walleij, alsi, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, pabeni, robh+dt, krzk+dt, arinc.unal, Luiz Angelo Daros de Luca, devicetree Realtek switches can use a reset controller instead of reset-gpios. Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Cc: devicetree@vger.kernel.org Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml index 46e113df77c8..70b6bda3cf98 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml @@ -59,6 +59,9 @@ properties: description: GPIO to be used to reset the whole device maxItems: 1 + resets: + maxItems: 1 + realtek,disable-leds: type: boolean description: | -- 2.42.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller 2023-11-11 21:51 ` [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller Luiz Angelo Daros de Luca @ 2023-11-13 8:31 ` Linus Walleij 2023-11-14 12:23 ` Alvin Šipraga 2023-11-16 16:25 ` Rob Herring 2 siblings, 0 replies; 9+ messages in thread From: Linus Walleij @ 2023-11-13 8:31 UTC (permalink / raw) To: Luiz Angelo Daros de Luca Cc: netdev, alsi, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, pabeni, robh+dt, krzk+dt, arinc.unal, devicetree On Sat, Nov 11, 2023 at 10:57 PM Luiz Angelo Daros de Luca <luizluca@gmail.com> wrote: > Realtek switches can use a reset controller instead of reset-gpios. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller 2023-11-11 21:51 ` [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller Luiz Angelo Daros de Luca 2023-11-13 8:31 ` Linus Walleij @ 2023-11-14 12:23 ` Alvin Šipraga 2023-11-16 16:25 ` Rob Herring 2 siblings, 0 replies; 9+ messages in thread From: Alvin Šipraga @ 2023-11-14 12:23 UTC (permalink / raw) To: Luiz Angelo Daros de Luca Cc: netdev@vger.kernel.org, linus.walleij@linaro.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzk+dt@kernel.org, arinc.unal@arinc9.com, devicetree@vger.kernel.org On Sat, Nov 11, 2023 at 06:51:05PM -0300, Luiz Angelo Daros de Luca wrote: > Realtek switches can use a reset controller instead of reset-gpios. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > --- > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > index 46e113df77c8..70b6bda3cf98 100644 > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml > @@ -59,6 +59,9 @@ properties: > description: GPIO to be used to reset the whole device > maxItems: 1 > > + resets: > + maxItems: 1 > + > realtek,disable-leds: > type: boolean > description: | > -- > 2.42.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller 2023-11-11 21:51 ` [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller Luiz Angelo Daros de Luca 2023-11-13 8:31 ` Linus Walleij 2023-11-14 12:23 ` Alvin Šipraga @ 2023-11-16 16:25 ` Rob Herring 2 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2023-11-16 16:25 UTC (permalink / raw) To: Luiz Angelo Daros de Luca Cc: arinc.unal, davem, vivien.didelot, andrew, f.fainelli, robh+dt, krzk+dt, linus.walleij, devicetree, alsi, netdev, olteanv, pabeni, kuba On Sat, 11 Nov 2023 18:51:05 -0300, Luiz Angelo Daros de Luca wrote: > Realtek switches can use a reset controller instead of reset-gpios. > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > Cc: devicetree@vger.kernel.org > Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-11-16 16:25 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231111215647.4966-1-luizluca@gmail.com>
2023-11-11 21:51 ` [RFC net-next 1/5] dt-bindings: net: dsa: realtek: reset-gpios is not required Luiz Angelo Daros de Luca
2023-11-12 7:37 ` Krzysztof Kozlowski
2023-11-13 20:30 ` Luiz Angelo Daros de Luca
2023-11-13 8:31 ` Linus Walleij
2023-11-14 12:23 ` Alvin Šipraga
2023-11-11 21:51 ` [RFC net-next 2/5] dt-bindings: net: dsa: realtek: add reset controller Luiz Angelo Daros de Luca
2023-11-13 8:31 ` Linus Walleij
2023-11-14 12:23 ` Alvin Šipraga
2023-11-16 16:25 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).