From: Krzysztof Kozlowski <krzk@kernel.org>
To: wangshuaijie@awinic.com
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
jic23@kernel.org, kangjiajun@awinic.com, krzk+dt@kernel.org,
lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, liweilei@awinic.com,
robh@kernel.org, waqar.hameed@axis.com
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor
Date: Thu, 25 Jul 2024 15:53:00 +0200 [thread overview]
Message-ID: <87498937-a331-4e80-afec-443f85796776@kernel.org> (raw)
In-Reply-To: <20240725124753.890589-1-wangshuaijie@awinic.com>
On 25/07/2024 14:47, wangshuaijie@awinic.com wrote:
>
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + description:
>>> + Set the number of the SAR(Specific Absorption Rate) sensor.
>>> + It is set to 0 if one awinic sar chip is used.
>>> + If two awinic sar chips are used, awinic,sar-label in the first
>>> + awinic-sar should be set to 0 and awinic,sar-label in the second
>>> + awinic-sar should be set to 1.
>>> + In an application where a device utilizes multiple proximity sensors,
>>> + it is used to retrieve the names of the register configuration files
>>> + that the drivers need to load. For example: aw963xx_reg_0.bin/aw963xx_reg_1.bin
>>> +
>>> + awinic,regulator-power-supply:
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
>>
>
> The patch for v4 will fix these issues.
Really? I commented here that you did not test it, so let's look at v4
and see if you tested it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-25 13:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:31 [PATCH V3 0/2] Add support for Awinic SAR sensor wangshuaijie
2024-07-12 11:31 ` [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor wangshuaijie
2024-07-12 11:55 ` Krzysztof Kozlowski
2024-07-13 12:15 ` Jonathan Cameron
2024-07-25 12:47 ` wangshuaijie
2024-07-25 13:53 ` Krzysztof Kozlowski [this message]
2024-07-12 12:34 ` Rob Herring (Arm)
2024-07-12 11:32 ` [PATCH V3 2/2] Add support for " wangshuaijie
2024-07-12 12:01 ` Krzysztof Kozlowski
2024-07-25 12:48 ` wangshuaijie
2024-07-12 14:33 ` Markus Elfring
2024-07-12 22:22 ` kernel test robot
2024-07-13 6:15 ` kernel test robot
2024-07-13 8:50 ` kernel test robot
2024-07-13 10:33 ` kernel test robot
2024-07-13 14:27 ` Jonathan Cameron
2024-07-25 12:47 ` wangshuaijie
2024-07-27 12:22 ` Jonathan Cameron
2024-07-12 11:49 ` [PATCH V3 0/2] Add support for Awinic SAR sensor Waqar Hameed
2024-07-25 12:48 ` wangshuaijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87498937-a331-4e80-afec-443f85796776@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kangjiajun@awinic.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=robh@kernel.org \
--cc=wangshuaijie@awinic.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).