From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94CE11E47B3; Thu, 14 Nov 2024 02:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731550075; cv=none; b=o30xBY4HsnIJPd8DyvAUYnAd4o1PeehQ4sfl6u+T9J2JkdQaTJijICp9h1N/HKFMgVaamEu2jbnzx7Ls/hZ2bd63u+2zFDSkF0CrtVxX7CKcCAOzLVaEmDaqgpJgr+D9gWCuvB3hFFd8UggmLGWLA6pcWWfnno4tifipTW5TP3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731550075; c=relaxed/simple; bh=BBfagTzfNiRjzEL6QJhFtCCEuOrztefDgMR7OwNToOQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=m118/CsnNRxyLZcTU0Sp87hTlviBCVeFhEY+17Yp8OP3EsIjcaz4v+8S9dOUFwEILLJkoGvAGq55AsEQDriSS+q8uAYutPVTkwiD/TSPs1ihp4gKwee633/4yNb3lGBVd6GujUP94LnCD6GgZJJRnpTyKNNjTDO/UFNntimr+Vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=AFAy1znJ; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="AFAy1znJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1731550068; bh=BBfagTzfNiRjzEL6QJhFtCCEuOrztefDgMR7OwNToOQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AFAy1znJh6ppKfBr4FJa0ACTelaEk8pXJsDu8CS3b2wQm+PJYmzITG/Ntgwi6snio BpMtbHlgSXuvYotDSHnriKnophoLxPHJck3I1ztJ5QnMHLMIe6plxj5ivLMe5S6eZf j8RPk3oTBtQ8SQca8/FMbcnGWZcqklbXIifxkoIb5YA7dy+qfv8NvrQczYYTa9R+Np 6Cv2GVWJnpq/Y0MBm722o3umVRoBgi95qcCBYG2lXMkefPWV3dedjZZBUIQVTExEaE EC1VBbzFB60eT4/0UA/qyEBY4VRst2WF04R0eoKyN+7Iu1ar5ROmGxSLlSv3xSbzpY U/JNmL/8vFO9Q== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Xpk7l64Qxz4wcT; Thu, 14 Nov 2024 13:07:47 +1100 (AEDT) From: Michael Ellerman To: Geert Uytterhoeven Cc: "Rob Herring (Arm)" , Saravana Kannan , linuxppc-dev@lists.ozlabs.org, Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling In-Reply-To: References: <20241106171028.3830266-1-robh@kernel.org> <87jzdfcm3l.fsf@mpe.ellerman.id.au> Date: Thu, 14 Nov 2024 13:07:49 +1100 Message-ID: <874j4ava8a.fsf@mpe.ellerman.id.au> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Geert Uytterhoeven writes: > On Thu, Nov 7, 2024 at 12:37=E2=80=AFPM Michael Ellerman wrote: >> "Rob Herring (Arm)" writes: >> > While OpenFirmware originally allowed walking parent nodes and default >> > root values for #address-cells and #size-cells, FDT has long required >> > explicit values. It's been a warning in dtc for the root node since the >> > beginning (2005) and for any parent node since 2007. Of course, not all >> > FDT uses dtc, but that should be the majority by far. The various >> > extracted OF devicetrees I have dating back to the 1990s (various >> > PowerMac, OLPC, PASemi Nemo) all have explicit root node properties. >> >> I have various old device trees that have been given to me over the >> years, and as far as I can tell they all have these properties (some of >> them are partial trees so it's hard to be 100% sure). > > Apparently CHRP LongTrail only had #address-cells in the root node. > Interestingly, /cpus does have a (zero) @size-cells property. > http://g33rt.be/migrated/Linux/PPC/root.html > http://g33rt.be/migrated/Linux/PPC/DeviceTree.html > > No idea if any of them are still alive. OK. We could fix that up in prom_init() if necessary - there's already a bunch of workarounds in there for longtrail. cheers