devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Ding Tao <miyatsu@qq.com>
Cc: jason@lakedaemon.net, andrew@lunn.ch,
	sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
	mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: marvell: armada-37xx: Enable emmc on espressobin
Date: Fri, 30 Nov 2018 18:58:38 +0100	[thread overview]
Message-ID: <874lbymoq9.fsf@bootlin.com> (raw)
In-Reply-To: <20181026115028.193203-2-miyatsu@qq.com> (Ding Tao's message of "Fri, 26 Oct 2018 11:50:28 +0000")

Hi Ding,
 
 On ven., oct. 26 2018, Ding Tao <miyatsu@qq.com> wrote:

> The ESPRESSObin board has a emmc interface available on U11, let's
> enable it.


Applied on mvebu/dt64 for now, but what happen if U11 is not populated?

Thanks,

Gregory

>
> Signed-off-by: Ding Tao <miyatsu@qq.com>
> ---
>  .../dts/marvell/armada-3720-espressobin.dts    | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> index 3ab25ad402b9..ee05aabbba88 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> @@ -60,6 +60,24 @@
>  	cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
>  	marvell,pad-type = "sd";
>  	vqmmc-supply = <&vcc_sd_reg1>;
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdio_pins>;
> +	status = "okay";
> +};
> +
> +/* U11 */
> +&sdhci0 {
> +	non-removable;
> +	bus-width = <8>;
> +	mmc-ddr-1_8v;
> +	mmc-hs400-1_8v;
> +	marvell,xenon-emmc;
> +	marvell,xenon-tun-count = <9>;
> +	marvell,pad-type = "fixed-1-8v";
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc_pins>;
>  	status = "okay";
>  };
>  
> -- 
> 2.17.1
>
>
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

      reply	other threads:[~2018-11-30 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 11:50 [PATCH 1/2] arm64: dts: marvell: armada37xx: Add emmc/sdio pinctrl definition Ding Tao
2018-10-26 11:50 ` [PATCH 2/2] arm64: dts: marvell: armada-37xx: Enable emmc on espressobin Ding Tao
2018-11-30 17:58   ` Gregory CLEMENT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lbymoq9.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=miyatsu@qq.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).