From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding Date: Fri, 22 Jun 2018 12:41:14 +0200 Message-ID: <874lhvnlx1.fsf@belgarion.home> References: <20180621154356.5438-1-robert.jarzmik@free.fr> <20180621154356.5438-2-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Takashi Iwai's message of "Thu, 21 Jun 2018 21:45:46 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai , Mark Rutland , Rob Herring Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown List-Id: devicetree@vger.kernel.org Takashi Iwai writes: >> Special review query: review the "return of_node_get(node)", which >> assumes that upon device removal, of_put_node(dev.of_node) will be >> called... > > Is it really done automagically? I couldn't spot it. Neither could I ... I based this on device_set_of_node_from_dev(), and the it "seemed" logical to me that a device probed from devicetree would take a refcnt on the devicetree node. As the "logical" conflicted with my search for the automagical of_node_get(), I need the special review query. Cheers. -- Robert