From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3990C47088 for ; Fri, 2 Dec 2022 16:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233827AbiLBQ0s (ORCPT ); Fri, 2 Dec 2022 11:26:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233764AbiLBQ0r (ORCPT ); Fri, 2 Dec 2022 11:26:47 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 283672AE5 for ; Fri, 2 Dec 2022 08:26:46 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id b9so5969063ljr.5 for ; Fri, 02 Dec 2022 08:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0UF5I9xvAaNLvIJujC4MXTflu00bNErvoIoO/UHyR+U=; b=MMHLX/rYkTO6DNuNz5CGYYz2/LRrC4kK+iaqOPC2lld4zqAcWZQDW9JwxgFmSRVK43 soc+3LnasSwCmZV7er/Eqp1x3hFIeaWBgKheWS1ih+GwvTD4TZvvfhl3ob/nnmvy1Bog H7cx9W3Vmz/F6Rg98rPxb9KwGI0qaHciECzbf4lfz/g0Bc9l9AKDlD45Q+7iigmTuW3R hRPxDRPD20+Ypn73lFvbQgkklMQR13Mhd/qTXcU2nzVRNTkdJ5CsuNZGetmyW9YHMiuL VeAn9Gx0J4vlJKVBA1S+VA+igDqwMTawlKO9Em6bbnmNcR50RQygshB0pw+R/NKo3cpy GCww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0UF5I9xvAaNLvIJujC4MXTflu00bNErvoIoO/UHyR+U=; b=JOpuvrxoa6o3A4i0l826QGGFJj42PmNa1OWp2R6KQOSRn7fFoBvWboHAiVg74hBlgl g2f85krpQMZeFYf1p5sEvRzTaktqMtCBVJBIaiPhKxRswdGe49Zew23EJt26YTaRUOY9 usS68viQb56gCVdVDPF6r5tpARiGbXoH5ay18nya9fGzm5eRBy93e21ODMkU9qbJeCu1 ehUeHBqf7NBmB8M75gg3+i2GXOev15CDNZB3StzYkL57oOqXbV09GD8T8AzWVv2wJi/q 2QB8vtE4JG+VgoWYBl3fskxs6XtEOMQKx3dz0EtrJN2QLPeOx+ir94/Qr5UWH/xGQqsd bIYg== X-Gm-Message-State: ANoB5pnXNrMmJQ3HnkJfMvCwulABTNi0BoVgwhKwwlJ/vvbpVZgUkn6d e4rFrLUkvUcDaKIwgKDicCf2iw== X-Google-Smtp-Source: AA0mqf5lCR6dD2t++a9tnKVO+0/luzxPDifl4p+kmYbtSEFfuYBxDaWMLm1Fiibk9ZBslnwyiuaqqw== X-Received: by 2002:a2e:b90a:0:b0:278:ec8b:4783 with SMTP id b10-20020a2eb90a000000b00278ec8b4783mr18134537ljb.91.1669998404415; Fri, 02 Dec 2022 08:26:44 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id f14-20020a05651c03ce00b0027998486803sm661724ljp.130.2022.12.02.08.26.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 08:26:43 -0800 (PST) Message-ID: <875a9a21-1cb7-3708-30f1-af6dd48e4f20@linaro.org> Date: Fri, 2 Dec 2022 17:26:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/3] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name Content-Language: en-US To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221202155738.383301-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/12/2022 17:18, Doug Anderson wrote: > Hi, > > On Fri, Dec 2, 2022 at 8:08 AM Doug Anderson wrote: >> >> Hi, >> >> On Fri, Dec 2, 2022 at 7:57 AM Krzysztof Kozlowski >> wrote: >>> >>> The pin config entry should have a string, not number, for the GPIO used >>> as WCD9340 audio codec interrupt. >>> >>> Reported-by: Doug Anderson >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> Cc: Doug Anderson >>> >>> Changes since v2: >>> 1. New patch. >>> --- >>> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Presumably should have a "Fixes" tag since this is likely a true bug. >> >> Reviewed-by: Douglas Anderson > > FWIW, this got copy-pasta-ed to another place, which I just noticed as > I'm looking at your v3. So while your change is correct, it'd be > better to also fix "sdm845-xiaomi-beryllium-common.dtsi" Yep... Best regards, Krzysztof