From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25846C77B76 for ; Fri, 14 Apr 2023 11:32:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjDNLcP (ORCPT ); Fri, 14 Apr 2023 07:32:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbjDNLcO (ORCPT ); Fri, 14 Apr 2023 07:32:14 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A99CBAF39 for ; Fri, 14 Apr 2023 04:31:53 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id xi5so44750622ejb.13 for ; Fri, 14 Apr 2023 04:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681471904; x=1684063904; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1jwXYFBzbS7qmut3eza5zD1XmDDlqA0VGbM9zH71iqE=; b=uz3YGGGh1WIUzK5nb6vzZtT+IWY9+fITr45V4nvz/hxzO1MqXi2UhqV03a68CRNyEG 5tlTNUL23h7HjO7AifGn/HAxZ0OAa2ofd31mCkx5k081sEK8ApwJ8DyxRLH2csldMbAX SHt12haQsUfxxLVbexh412tIksTtO91ovpZB07eE7lYAKvtlqhFqi9efrTQrxFe3KRb5 LLKw+tsH0yZoIQf2PwCEybCiXNOoZcug8N0fPIkVwrEHPblWciukInisZN3fcixdOSb/ shLjDgbkbs2KrxQoyBifk+T11G54g9c+W3JAr80Q73XCtPX8V8nH1BQ/ARroUjZvOa6J k5kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681471904; x=1684063904; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1jwXYFBzbS7qmut3eza5zD1XmDDlqA0VGbM9zH71iqE=; b=gDUfNZk0Ac18bE+1XgHLfFk4WTg6P26wX/eT9vNgPMbPtad65dpItYaLsNQtG8Idno uxA0tvhNiqsai85qgf5KfLjQQlkXLsiaJs5Wdrdp4shxIn8LDRArk2ay+Rn7NY5CBP1a S1BkP0hQw2XH+NHG924dlrdh0BR4wIgOAB2Tlcwn4S8i/ZTZq+LtZzQKGFUCHT9E+2LO rT9nKagyukaE6E9m1OHbj5OS2KtjvtWG6WdlT3waMzTqUAYp90f8d6aeWVs8UbIXqmGM N3UBsMmLlkFdqAI66m/jEyrJ4VW42I1R0Kvu+bcfQ0tzPk42ieQGZDQf6LDOWw/KCAb1 SD7A== X-Gm-Message-State: AAQBX9epr6wBNwGPEi2l5W362lw/LHYBskTSk8skqtfVZfh65p916CTA Q7SEg0/9fkN0MLT1c2Cd93JdCA== X-Google-Smtp-Source: AKy350aBB3M1mZlxR5fmk5313CkKmhcQlFOBFoJdqAvGHGzTYdHq4T2OaQIjfb1exA/Ykuae0rqAyA== X-Received: by 2002:a17:906:3888:b0:94a:8a82:9cab with SMTP id q8-20020a170906388800b0094a8a829cabmr6016358ejd.42.1681471904108; Fri, 14 Apr 2023 04:31:44 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:40b9:8c57:b112:651d? ([2a02:810d:15c0:828:40b9:8c57:b112:651d]) by smtp.gmail.com with ESMTPSA id hs13-20020a1709073e8d00b0094ece70481csm1311311ejc.197.2023.04.14.04.31.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 04:31:43 -0700 (PDT) Message-ID: <875aaaa6-ac8a-fbf6-edd3-fde5444220b8@linaro.org> Date: Fri, 14 Apr 2023 13:31:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [EXT] Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI system atchdog driver Content-Language: en-US To: Bharat Bhushan , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230414102342.23696-1-bbhushan2@marvell.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2023 13:29, Bharat Bhushan wrote: > >> >>> + >>> +examples: >>> + - | >>> + soc { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + >>> + watchdog@802000040000 { >>> + compatible = "marvell-octeontx2-wdt"; >>> + reg = <0x8020 0x40000 0x0 0x20000>; >> >> Are you sure that this is correct DTS? 32-bit numbers are usually 8-digit long. Plus >> size of 0x20000 is crazy huge. And the unit address is a bit unusual. Are you sure >> dtc W=1 does not say about any errors in your DTS? > > Each cell is 32bit, so if we specify less than upper values becomes zeros (0s). ... and what is the convention/coding style of your subarch? Is to have short or 0-padded reg addresses? Anyway, I have doubts this was tested, so please confirm that dtbs W=1 and dtbs_check produce no errors on your DTS. BTW, where is the DTS? Best regards, Krzysztof