From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Chengci.Xu" <chengci.xu@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
srv_heupstream@mediatek.com
Subject: Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master
Date: Sat, 23 Jul 2022 19:32:49 +0200 [thread overview]
Message-ID: <875d6856-dea4-e1ff-60b3-706cf00f8bb9@linaro.org> (raw)
In-Reply-To: <20220723031955.12552-3-chengci.xu@mediatek.com>
On 23/07/2022 05:19, Chengci.Xu wrote:
Thank you for your patch. There is something to discuss/improve.
> #endif
> diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
> index 11f7d6b59642..76093b856335 100644
> --- a/include/soc/mediatek/smi.h
> +++ b/include/soc/mediatek/smi.h
> @@ -8,6 +8,15 @@
>
> #include <linux/bitops.h>
> #include <linux/device.h>
> +#include <linux/arm-smccc.h>
> +#include <linux/soc/mediatek/mtk_sip_svc.h>
The headers do not look like used here. Include only relevant headers.
> +
> +/* IOMMU & SMI ATF CMD */
> +
> +enum IOMMU_ATF_CMD {
> + IOMMU_ATF_CMD_CONFIG_SMI_LARB, /* For mm master to en/disable iommu */
> + IOMMU_ATF_CMD_COUNT,
> +};
>
> #if IS_ENABLED(CONFIG_MTK_SMI)
>
Best regards,
Krzysztof
next parent reply other threads:[~2022-07-23 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220723031955.12552-1-chengci.xu@mediatek.com>
[not found] ` <20220723031955.12552-3-chengci.xu@mediatek.com>
2022-07-23 17:32 ` Krzysztof Kozlowski [this message]
2022-07-23 17:33 ` [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875d6856-dea4-e1ff-60b3-706cf00f8bb9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=chengci.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).