* Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master
[not found] ` <20220723031955.12552-3-chengci.xu@mediatek.com>
@ 2022-07-23 17:32 ` Krzysztof Kozlowski
2022-07-23 17:33 ` Krzysztof Kozlowski
1 sibling, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-23 17:32 UTC (permalink / raw)
To: Chengci.Xu, Yong Wu, Rob Herring, Matthias Brugger
Cc: linux-mediatek, linux-kernel, devicetree, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, srv_heupstream
On 23/07/2022 05:19, Chengci.Xu wrote:
Thank you for your patch. There is something to discuss/improve.
> #endif
> diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
> index 11f7d6b59642..76093b856335 100644
> --- a/include/soc/mediatek/smi.h
> +++ b/include/soc/mediatek/smi.h
> @@ -8,6 +8,15 @@
>
> #include <linux/bitops.h>
> #include <linux/device.h>
> +#include <linux/arm-smccc.h>
> +#include <linux/soc/mediatek/mtk_sip_svc.h>
The headers do not look like used here. Include only relevant headers.
> +
> +/* IOMMU & SMI ATF CMD */
> +
> +enum IOMMU_ATF_CMD {
> + IOMMU_ATF_CMD_CONFIG_SMI_LARB, /* For mm master to en/disable iommu */
> + IOMMU_ATF_CMD_COUNT,
> +};
>
> #if IS_ENABLED(CONFIG_MTK_SMI)
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master
[not found] ` <20220723031955.12552-3-chengci.xu@mediatek.com>
2022-07-23 17:32 ` [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master Krzysztof Kozlowski
@ 2022-07-23 17:33 ` Krzysztof Kozlowski
1 sibling, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-23 17:33 UTC (permalink / raw)
To: Chengci.Xu, Yong Wu, Rob Herring, Matthias Brugger
Cc: linux-mediatek, linux-kernel, devicetree, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
On 23/07/2022 05:19, Chengci.Xu wrote:
> For concerns about security, the register to enable/disable IOMMU of
> SMI LARB should only be configured in secure world. Thus, we add some
> SMC command for multimedia master to enable/disable MM IOMMU in ATF by
> setting the register of SMI LARB. This function is prepared for MT8188.
Could you not Cc non-existing email addresses? It causes annoying
bounces every time I deal with Mediatek:
550 Relaying mail to srv_heupstream@mediatek.com is not allowed
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread