From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B3642B311; Fri, 10 Jul 2026 12:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783688383; cv=none; b=ltFhJKx/IfYci9OZ89F8DfuKuWgDsgaylvA7i943BZy/aMgQs4dKLqzBLAILdUeouZsNVolQbhVHL2Uf8BcoBrzx3Qkpkwxgi/N5J0gagBuV+/vRut7VpNWgWrChlelrDnclxtWwXN/g7FCFWX0NQBQsJiajlevsQSchEJNEtUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783688383; c=relaxed/simple; bh=/6sXJuUOctndqmdSaxuO2kvNa2414Xs031qJp2Qo3/0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=KpzWEd/vMwZlpwgtrLt1chiKxhXjf5xcYUcfqwtrgexh+89XeMft7heBe+NuWf4Piti6tqpQo1c4DjIu5cu3cjwpilkH/tT8dd2pZl/W/y8fMKJf2El2zwPBkhGufjTOJ2hk3gksAGo7I7wFXSKKvhdWyUyClry+b40//Msq5cY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=eBUf2nVN; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="eBUf2nVN" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 534DC4E40D46; Fri, 10 Jul 2026 12:59:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 1629960342; Fri, 10 Jul 2026 12:59:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7EEEB11BD041E; Fri, 10 Jul 2026 14:59:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1783688373; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=tVE3k2wNc11oGNnWAyHGoU5XfSdc5JYzcD9eXOmLp6c=; b=eBUf2nVN8AVKC6kOJnhTuK/k1N66T/yVJ/bHVl3sko1ofApykwoi8BTLKdwU8HriZh9YsS zJynoQn9LOafgWeqL29qT9ogxPZGhp+EhHgD6oMDDCEMjj97E/FbLfMCaa9KT6OefQ4jm/ 8IpPdMtr7Wbag7M4Tpv3pgyUYMvS/EyTAmO0PJFUGqUrJzu2/I2YIDHcQv1U9KWvGq56P2 /naUd+n9+sIYYhAjAWI0bNvHa9uygtCYzyCnWMZE4S2LJ9jscI3aItLSvm1kvO8FdG4smz kiyq7TvXWb79NO9mRBWB3GnW/rqAQR2400EF5ZK9djy6Mf13KuXeRXKAE7oHmA== From: Miquel Raynal To: Rob Herring Cc: Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Olivia Mackall , Herbert Xu , Jayesh Choudhary , "David S. Miller" , Christian Marangi , Antoine Tenart , Geert Uytterhoeven , Magnus Damm , Thomas Petazzoni , Pascal EBERHARD , Wolfram Sang , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 05/16] dt-bindings: bus: eip150: Describe the EIP-150 container node In-Reply-To: <20260407194449.GA3542959-robh@kernel.org> (Rob Herring's message of "Tue, 7 Apr 2026 14:44:49 -0500") References: <20260327-schneider-v7-0-rc1-crypto-v1-0-5e6ff7853994@bootlin.com> <20260327-schneider-v7-0-rc1-crypto-v1-5-5e6ff7853994@bootlin.com> <20260407194449.GA3542959-robh@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 10 Jul 2026 14:59:25 +0200 Message-ID: <875x2ngfv6.fsf@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 07/04/2026 at 14:44:49 -05, Rob Herring wrote: > On Fri, Mar 27, 2026 at 09:09:27PM +0100, Miquel Raynal (Schneider Electr= ic) wrote: >> Part of Inside-Secure's SafeXcel family, the EIP-150 is some kind of >> container node composed of: >> - a public key accelerator, >> - random number generator, >> - an interrupt controller. >>=20 >> It also acts as proxy for the clocks. >>=20 >> Signed-off-by: Miquel Raynal (Schneider Electric) >> --- >> .../bus/inside-secure,safexcel-eip150.yaml | 58 +++++++++++++++= +++++++ >> 1 file changed, 58 insertions(+) >>=20 >> diff --git a/Documentation/devicetree/bindings/bus/inside-secure,safexce= l-eip150.yaml b/Documentation/devicetree/bindings/bus/inside-secure,safexce= l-eip150.yaml >> new file mode 100644 >> index 000000000000..1b3d83a852f5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/bus/inside-secure,safexcel-eip15= 0.yaml >> @@ -0,0 +1,58 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/bus/inside-secure,safexcel-eip150.ya= ml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Inside-Secure SafeXcel EIP-150 container >> + >> +maintainers: >> + - Miquel Raynal >> + >> +description: >> + The EIP-150 is a hardware container, it has its own interrupt >> + controller inside to which a random number generator and a public key >> + accelerator are wired. >> + >> +allOf: >> + - $ref: simple-pm-bus.yaml# >> + - $ref: /schemas/clock/clock-nexus-node.yaml# > > Generally, if a schema has 'select: true', you don't reference it as it=20 > has already been applied. And you have to list the properties here=20 > anyways because you need to define how many #clock-cells for example. I see, I'll drop that line. Thanks for the explanation, very appreciated. >> +properties: >> + compatible: >> + items: >> + - const: inside-secure,safexcel-eip150 >> + - {} # simple-pm-bus, but not listed here to avoid false select >> + >> + clocks: >> + minItems: 1 Should be: maxItems: 1 I did the error once, and copy-pasted it two more times in this series. > Seems to me you are adding this to satisfy simple-pm-bus. Maybe this=20 > should just be simple-bus? I really need that clock, it feeds my container and is then populated through the child nodes. I actually selected simple-pm-bus on purpose, as my use case seems to really fit the description? >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 1 >> + >> + ranges: true >> + >> +patternProperties: >> + "^interrupt-controller@[0-9a-f]+$": >> + type: object >> + $ref: /schemas/interrupt-controller/inside-secure,safexcel-eip201.y= aml# > > Better to just list a compatible you require. Like this, the schema is=20 > applied twice. Mmmh, ok! >> + "^rng@[0-9a-f]+$": >> + type: object >> + $ref: /schemas/rng/inside-secure,safexcel-eip76.yaml# >> + >> + "^crypto@[0-9a-f]+$": >> + type: object >> + $ref: /schemas/crypto/inside-secure,safexcel-eip28.yaml# >> + >> +required: >> + - compatible >> + - clocks > >> + - "#address-cells" >> + - "#size-cells" >> + - ranges > > The bus schema requires all these already. I'll drop them. Thanks! Miqu=C3=A8l