Re: [PATCH v2] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes

[Gregory CLEMENT <gregory.clement@bootlin.com>]

+Miquèl

Hello Gabor,

Thanks it is better,

> The 'marvell,usb-misc-reg' property is present both in the EHCI and
> in the XHCI USB host device nodes, however it is not documented. Thus
> 'make dtbs_check' produces warnings like these:
>
>   /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>           from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
>   /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>           from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
>
> Apart from the fact that the properties are not documented, those are
> not even used by any USB host drivers. Due to this, drop the properties
> in order to get rid of the warnings.
>
> Note:
>
> With the same name, there is a property used for the Armada 3700 USB
> UTMI PHYs of which dt-bindings documentation has been added in commit
> e60958699afa ("dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings").
>
> Additionally, the property is handled by the 'phy-mvebu-a3700-utmi'
> driver since commit cc8b7a0ae866 ("phy: add A3700 UTMI PHY driver").
>
> When the nodes of the UTMI PHYs has been added to the SoC dtsi by
> commit 05d168a56fae ("arm64: dts: marvell: armada-37xx: declare USB2
> UTMI PHYs"), the properties has been added to the USB host controller
> nodes also. According to the commit message this was intentional,

Miquel will confirm that, after speaking with him, it appears to be a
mistake rather than an intentional act.

Grégory

> however in regard to the USB hosts, neither the respective documentation,
> nor driver support has been added into the tree since that.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
> Changes in v2:
>   - add Reviewed-by tag from Andrew
>   - change subject and reword commit message
>   - Link to v1: https://lore.kernel.org/r/20260304-armada-37xx-drop-usb-misc-reg-v1-1-800c1b746b7a@gmail.com
> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index ea1824f5321fbb32fc4373c08a0d94bca1dc793b..44c47409f8793ae1266303607812ef481edbfbc5 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -369,7 +369,6 @@ usb3: usb@58000 {
>  				compatible = "marvell,armada3700-xhci",
>  				"generic-xhci";
>  				reg = <0x58000 0x4000>;
> -				marvell,usb-misc-reg = <&usb32_syscon>;
>  				interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&sb_periph_clk 12>;
>  				phys = <&comphy0 0>, <&usb2_utmi_otg_phy>;
> @@ -393,7 +392,6 @@ usb32_syscon: system-controller@5d800 {
>  			usb2: usb@5e000 {
>  				compatible = "marvell,armada-3700-ehci";
>  				reg = <0x5e000 0x1000>;
> -				marvell,usb-misc-reg = <&usb2_syscon>;
>  				interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>  				phys = <&usb2_utmi_host_phy>;
>  				phy-names = "usb";
>
> ---
> base-commit: 98226a594f313442fcba38cefc1df0b6c1691c7e
> change-id: 20260304-armada-37xx-drop-usb-misc-reg-e9635498cae6
>
> Best regards,
> -- 
> Gabor Juhos <j4g8y7@gmail.com>
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com