[PATCH v2] dt-bindings: soc: renesas: Document R-Car X5H

[PATCH v2] dt-bindings: soc: renesas: Document R-Car X5H

[Kuninori Morimoto]

Document the compatible values for the Renesas R-Car X5H (R8A78000) SoC

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
	- add empty enum to avoid allowing invalid use.

 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index 5f9d541d177a..e2fec2afbc6d 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -473,6 +473,12 @@ properties:
           - const: renesas,r8a779mb
           - const: renesas,r8a7795
 
+      - description: R-Car X5H (R8A78000)
+        items:
+          - enum:
+              - {}               # avoid allowing invalid use. will be replaced to actual board name
+          - const: renesas,r8a78000
+
       - description: RZ/N1D (R9A06G032)
         items:
           - enum:
-- 
2.43.0

Re: [PATCH v2] dt-bindings: soc: renesas: Document R-Car X5H

[Krzysztof Kozlowski]

On Wed, Aug 27, 2025 at 11:34:09PM +0000, Kuninori Morimoto wrote:
> Document the compatible values for the Renesas R-Car X5H (R8A78000) SoC
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> 	- add empty enum to avoid allowing invalid use.

I don't understand why do you need this. Where is any user of it? There
is no such in this patchset, so this must be explicitly explained in the
commit msg.

> 
>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index 5f9d541d177a..e2fec2afbc6d 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -473,6 +473,12 @@ properties:
>            - const: renesas,r8a779mb
>            - const: renesas,r8a7795
>  
> +      - description: R-Car X5H (R8A78000)
> +        items:
> +          - enum:
> +              - {}               # avoid allowing invalid use. will be replaced to actual board name

We don't allow such cases because it is pointless.

Otherwise explain in the commit msg why this is needed, why exception is
justified.

You have entire commit msg to explain anything unusual and if you look
at source code you will not notice such syntax for boards, so clearly
this is unusual.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: soc: renesas: Document R-Car X5H

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

On Thu, Aug 28, 2025 at 09:27:19AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Aug 27, 2025 at 11:34:09PM +0000, Kuninori Morimoto wrote:
> > Document the compatible values for the Renesas R-Car X5H (R8A78000) SoC
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > v1 -> v2
> > 	- add empty enum to avoid allowing invalid use.
> 
> I don't understand why do you need this. Where is any user of it? There
> is no such in this patchset, so this must be explicitly explained in the
> commit msg.
> 
> > 
> >  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > index 5f9d541d177a..e2fec2afbc6d 100644
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -473,6 +473,12 @@ properties:
> >            - const: renesas,r8a779mb
> >            - const: renesas,r8a7795
> >  
> > +      - description: R-Car X5H (R8A78000)
> > +        items:
> > +          - enum:
> > +              - {}               # avoid allowing invalid use. will be replaced to actual board name
> 
> We don't allow such cases because it is pointless.
> 
> Otherwise explain in the commit msg why this is needed, why exception is
> justified.
> 
> You have entire commit msg to explain anything unusual and if you look
> at source code you will not notice such syntax for boards, so clearly
> this is unusual.

They have a soc driver that binds to the compatible, which is why I
suggested this rather than refusing the patch. I do agree it should be
mentioned though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] dt-bindings: soc: renesas: Document R-Car X5H

[Kuninori Morimoto]

Hi Krzysztof, Conor, Geert

> > > v1 -> v2
> > > 	- add empty enum to avoid allowing invalid use.
> > 
> > I don't understand why do you need this. Where is any user of it? There
> > is no such in this patchset, so this must be explicitly explained in the
> > commit msg.
(snip)
> > We don't allow such cases because it is pointless.
> > 
> > Otherwise explain in the commit msg why this is needed, why exception is
> > justified.
> > 
> > You have entire commit msg to explain anything unusual and if you look
> > at source code you will not notice such syntax for boards, so clearly
> > this is unusual.
> 
> They have a soc driver that binds to the compatible, which is why I
> suggested this rather than refusing the patch. I do agree it should be
> mentioned though.

OK, let's skip this patch and post it with both SoC and Board name.
Which was my original plan.


Thank you for your help !!

Best regards
---
Kuninori Morimoto