From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q/KtpZVt" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D649100 for ; Mon, 20 Nov 2023 11:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700509049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BlYDIXP3w1RwZl506oGiJVMb8cguIu5a7QZETE7Ax68=; b=Q/KtpZVtqDO0Ri+wn99KRVbe6gmO3GOLMdYYjbjMueMOlb/+9y+jzghujvsjL8pa37mXC1 beiXEjQPzgGcHUJ4pRjq1mGbNJvud6jU1nlDcNLZEvuGTKMQZ+qhDa3nNsOGWhr9ObKlVU rwdjwXhw8GYTcwWW36yGeo4Z5MbapG4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-Drk6YX9UM9abjmkAuHstfQ-1; Mon, 20 Nov 2023 14:37:27 -0500 X-MC-Unique: Drk6YX9UM9abjmkAuHstfQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40839252e81so14308565e9.3 for ; Mon, 20 Nov 2023 11:37:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700509046; x=1701113846; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BlYDIXP3w1RwZl506oGiJVMb8cguIu5a7QZETE7Ax68=; b=fFqugDwIlz4TUVzq0WrZeHScAbcun2fa3aiq+IBVYhz6yxJx/c0QQpKSZhgPyLDHCH /b14LPMM3+Tzu7OQuFkBd8UyKOMD7ZDODoULZCKPBpUXGc6xNTdZmpeUDYLv/9b56oZB Nkn9gr+BgiSC1ePBUaixC6j78hs2tcFY0+ehGIh1+m7F/wiGIVnTvnwXYN6pYkovryr7 VyLuJwuQQPBVJXPTbyk7SVSleXR3xhjxhb5L5ojv3R+OqV69hnGYZMnvwhtxhgStFQjR PH9sro1FTcG6hk+jhqwSE4mGRxWN92TyXEokvQiSb9+aJO4EnSWYFqbqNn2bWERqmXej rtuQ== X-Gm-Message-State: AOJu0YywqvJwIDa3d8UjsUJV0d3fUrEwDnCZ4zU6wxsDgbw93S0oxhgi lmWiC0IEMPiihq2VrWJwfZnKkqMVNgUtn7kk9rYt+qzcsLQNAl2kQPvzfXu1nhcStq+3uoM0057 qGLmY7hMsabWgV34dZ+fWCA== X-Received: by 2002:a05:6000:1449:b0:32f:79de:8b7f with SMTP id v9-20020a056000144900b0032f79de8b7fmr6540620wrx.49.1700509046782; Mon, 20 Nov 2023 11:37:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjy7cAUf+TVSzll5QOp+4fMVTMb5WaOIECh3Za1iXn2WmoxuC6GE30PNx+sjRVl9ZTc2F8vQ== X-Received: by 2002:a05:6000:1449:b0:32f:79de:8b7f with SMTP id v9-20020a056000144900b0032f79de8b7fmr6540600wrx.49.1700509046385; Mon, 20 Nov 2023 11:37:26 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p2-20020a5d4582000000b003316d1a3b05sm10763235wrq.78.2023.11.20.11.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 11:37:26 -0800 (PST) From: Javier Martinez Canillas To: Conor Dooley Cc: linux-kernel@vger.kernel.org, Sahaj Sarup , Conor Dooley , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Rob Herring , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3] dt-bindings: display: ssd1307fb: Change "solomon,page-offset" default value In-Reply-To: <20231120-granola-sturdy-83d054f1b6fa@spud> References: <20231116180743.2763021-1-javierm@redhat.com> <20231120-granola-sturdy-83d054f1b6fa@spud> Date: Mon, 20 Nov 2023 20:37:25 +0100 Message-ID: <875y1w2p3e.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Conor Dooley writes: Hello Connor, > On Thu, Nov 16, 2023 at 07:07:37PM +0100, Javier Martinez Canillas wrote: >> This is used to specify the page start address offset of the display RAM. >> >> The value is used as offset when setting the page start address with the >> SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to >> 1 if the property is not present in the Device Tree. >> >> But the datasheet mentions that the value on reset for the page start is a >> 0, so it makes more sense to also have 0 as the default value for the page >> offset if the property is not present. >> >> In fact, using a default value of 1 leads to the display not working when >> the fbdev is attached to the framebuffer console. >> >> Reported-by: Sahaj Sarup >> Signed-off-by: Javier Martinez Canillas >> --- >> >> .../devicetree/bindings/display/solomon,ssd1307fb.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> index 3afbb52d1b7f..badd81459aaa 100644 >> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> @@ -35,7 +35,7 @@ properties: >> >> solomon,page-offset: >> $ref: /schemas/types.yaml#/definitions/uint32 >> - default: 1 >> + default: 0 > > I think I saw it pointed out by Maxime elsewhere that this breaks the > ABI. It would be nice if DT defaults matched the hardware's, but I don't > really think it is worth breaking the ABI here. Expanding the property Yes, Maxime also agrees with you as you mentioned. It's fair to say that this may affect potential users even when I honestly think that's unlikely. I'll just discard these patches and point out to people reporting the same problem than Sahaj, that they need to add a "solomon,page-offset" property. > description to explain the impact of the particular values might help > with incorrect usage. > I'm unsure how much that would help to be honest but I might post a patch. > Thanks, > Conor. > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat