From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Date: Wed, 19 Jul 2017 09:36:59 +0530 Message-ID: <87734375-8841-ce74-38eb-7ee5af1ad4f6@ti.com> References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-5-git-send-email-j-keerthy@ti.com> <1cd6ef99-a98e-7cdb-5c2a-f5cd057eef41@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1cd6ef99-a98e-7cdb-5c2a-f5cd057eef41-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Suman Anna , linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, fcooper-l0cyMroinI0@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 19 July 2017 12:43 AM, Suman Anna wrote: > Hi Keerthy, > > On 07/18/2017 05:57 AM, Keerthy wrote: >> keystone-k2g has 2 instances of gpio. The first one has all the 144 GPIOs > > Please use 66AK2G for keystone-k2g. Okay > >> functional( 9 banks with 16 gpios = 144). The second instance has >> only the GPIO0:GPIO67 functional and rest are marked reserved. >> >> Signed-off-by: Keerthy >> --- >> arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi >> index bf4d1fa..58ac3db 100644 >> --- a/arch/arm/boot/dts/keystone-k2g.dtsi >> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi >> @@ -15,6 +15,7 @@ >> >> #include >> #include >> +#include >> >> / { >> compatible = "ti,k2g","ti,keystone"; >> @@ -168,5 +169,46 @@ >> #reset-cells = <2>; >> }; >> }; >> + >> + gpio0: gpio@2603000 { >> + compatible = "ti,keystone-k2g-gpio"; >> + reg = <0x02603000 0x100>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + ti,ngpio = <144>; >> + ti,davinci-gpio-unbanked = <0>; >> + clocks = <&k2g_clks 0x001b 0x0>; >> + clock-names = "gpio"; > > I don't see the clocks and clock-names documented in the binding. > Looking at davinci_gpio_irq_setup(), these are required, and a specific > clock name is what the driver is looking for. And you have different > semantics for this on K2G and non-K2G SoCs. Davinci platforms are using > non-DT clocks, so their DT nodes didn't have them. I will document the same. > > regards > Suman > >> + }; >> + >> + gpio1: gpio@260a000 { >> + compatible = "ti,keystone-k2g-gpio"; >> + reg = <0x0260a000 0x100>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupts = , >> + , >> + , >> + , >> + ; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + ti,ngpio = <68>; >> + ti,davinci-gpio-unbanked = <0>; >> + clocks = <&k2g_clks 0x001c 0x0>; >> + clock-names = "gpio"; >> + }; >> }; >> }; >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html