From: Baruch Siach <baruch@tkos.co.il>
To: Stefan Eichenberger <eichest@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Stefan Eichenberger <eichest@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@armlinux.org.uk>,
Rabeeh Khoury <rabeeh@solid-run.com>
Subject: Re: [PATCH] arm64: dts: clearfog-gt-8k: fix ge phy reset pin
Date: Sun, 29 Mar 2020 09:22:03 +0300 [thread overview]
Message-ID: <877dz3el4k.fsf@tarshish> (raw)
In-Reply-To: <20200328212115.12477-1-eichest@gmail.com>
Hi Stefan,
On Sun, Mar 29 2020, eichest@gmail.com wrote:
> From: Stefan Eichenberger <eichest@gmail.com>
>
> According to the ClearFog-GT-8K-rev-1_1-Simplified-Schematic the reset
> pin for the gigabit phy is MPP62 and not MPP43.
Have you tested that on real hardware?
The 1Gb PHY reset on my Clearfog GT-8K is connected to MPP43. Russell's
commit 46f94c7818e7 ("arm64: dts: clearfog-gt-8k: set gigabit PHY reset
deassert delay") indicates that this is the case on his board as well.
In case there was a hardware change between board revisions, we need
another dtb for that revision.
baruch
> Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
> ---
> .../dts/marvell/armada-8040-clearfog-gt-8k.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index b90d78a5724b..d371d938b41e 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -144,7 +144,6 @@
> * [35-38] CP0 I2C1 and I2C0
> * [39] GPIO reset button
> * [40,41] LED0 and LED1
> - * [43] 1512 phy reset
> * [47] USB VBUS EN (active low)
> * [48] FAN PWM
> * [49] SFP+ present signal
> @@ -155,6 +154,7 @@
> * [54] NFC reset
> * [55] Micro SD card detect
> * [56-61] Micro SD
> + * [62] 1512 phy reset
> */
>
> cp0_pci0_reset_pins: pci0-reset-pins {
> @@ -197,11 +197,6 @@
> marvell,function = "gpio";
> };
>
> - cp0_copper_eth_phy_reset: copper-eth-phy-reset {
> - marvell,pins = "mpp43";
> - marvell,function = "gpio";
> - };
> -
> cp0_xhci_vbus_pins: xhci0-vbus-pins {
> marvell,pins = "mpp47";
> marvell,function = "gpio";
> @@ -232,6 +227,11 @@
> "mpp60", "mpp61";
> marvell,function = "sdio";
> };
> +
> + cp0_copper_eth_phy_reset: copper-eth-phy-reset {
> + marvell,pins = "mpp62";
> + marvell,function = "gpio";
> + };
> };
>
> &cp0_pcie0 {
> @@ -365,7 +365,7 @@
> reg = <0>;
> pinctrl-names = "default";
> pinctrl-0 = <&cp0_copper_eth_phy_reset>;
> - reset-gpios = <&cp0_gpio2 11 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&cp0_gpio2 30 GPIO_ACTIVE_LOW>;
> reset-assert-us = <10000>;
> reset-deassert-us = <10000>;
> };
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2020-03-29 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 21:21 [PATCH] arm64: dts: clearfog-gt-8k: fix ge phy reset pin eichest
2020-03-29 6:22 ` Baruch Siach [this message]
2020-03-29 8:42 ` Rabeeh Khoury
2020-03-29 9:20 ` Stefan Eichenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dz3el4k.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=eichest@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rabeeh@solid-run.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).