From: Yoshinori Sato <ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: uclinux-h8-devel-5NWGOfrQmneRv+LV9MX5uooqe+aC9MnS@public.gmane.org,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: renesas,h8300-bsc
Date: Mon, 29 Jun 2015 23:48:24 +0900 [thread overview]
Message-ID: <877fqmh8p3.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <CAMuHMdUUt6pgYqz35MyxSEnOds3Ji9CpQMU4m4ihqS_PO6ei=w@mail.gmail.com>
On Mon, 29 Jun 2015 18:51:13 +0900,
Geert Uytterhoeven wrote:
>
> Hi Sato-san,
>
> Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt says:
>
> +Required properties:
> + - compatible: Must be "renesas,h8300-bsc".
> + - reg: Base address and length of BSC registers.
>
> But the example uses another compatible value, which is not documented,
> in addition to the one above:
>
> +Example.
> + bsc: memory-controller@fee01e {
> + compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
> + reg = <0xfee01e 8>;
> + };
>
> The example matches the simulator's dts:
>
> h8300h_sim.dts: compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
>
> But the dtses for real hardware use yet another undocumented value:
>
> edosk2674.dts: compatible = "renesas,h8s-bsc", "renesas,h8300-bsc";
> h8s_sim.dts: compatible = "renesas,h8s-bsc", "renesas,h8300-bsc";
>
> Can you please fix this?
OK.
A document doesn't catch up code.
> BTW, scripts/checkpatch.pl should have told you about some of the
> discrepancies.
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Yoshinori Sato
<ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-06-29 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 9:51 renesas,h8300-bsc Geert Uytterhoeven
2015-06-29 14:48 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fqmh8p3.wl-ysato@users.sourceforge.jp \
--to=ysato-rn4veauk+akrv+lv9mx5uooqe+ac9mns@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=uclinux-h8-devel-5NWGOfrQmneRv+LV9MX5uooqe+aC9MnS@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).