renesas,h8300-bsc

renesas,h8300-bsc

[Geert Uytterhoeven]

Hi Sato-san,

Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt says:

+Required properties:
+  - compatible: Must be "renesas,h8300-bsc".
+  - reg: Base address and length of BSC registers.

But the example uses another compatible value, which is not documented,
in addition to the one above:

+Example.
+       bsc: memory-controller@fee01e {
+               compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
+               reg = <0xfee01e 8>;
+       };

The example matches the simulator's dts:

h8300h_sim.dts: compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";

But the dtses for real hardware use yet another undocumented value:

edosk2674.dts: compatible = "renesas,h8s-bsc", "renesas,h8300-bsc";
h8s_sim.dts: compatible = "renesas,h8s-bsc", "renesas,h8300-bsc";

Can you please fix this?

BTW, scripts/checkpatch.pl should have told you about some of the
discrepancies.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: renesas,h8300-bsc

[Yoshinori Sato]

On Mon, 29 Jun 2015 18:51:13 +0900,
Geert Uytterhoeven wrote:
> 
> Hi Sato-san,
> 
> Documentation/devicetree/bindings/memory-controllers/renesas,h8300-bsc.txt says:
> 
> +Required properties:
> +  - compatible: Must be "renesas,h8300-bsc".
> +  - reg: Base address and length of BSC registers.
> 
> But the example uses another compatible value, which is not documented,
> in addition to the one above:
> 
> +Example.
> +       bsc: memory-controller@fee01e {
> +               compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
> +               reg = <0xfee01e 8>;
> +       };
> 
> The example matches the simulator's dts:
> 
> h8300h_sim.dts: compatible = "renesas,h8300h-bsc", "renesas,h8300-bsc";
> 
> But the dtses for real hardware use yet another undocumented value:
> 
> edosk2674.dts: compatible = "renesas,h8s-bsc", "renesas,h8300-bsc";
> h8s_sim.dts: compatible = "renesas,h8s-bsc", "renesas,h8300-bsc";
> 
> Can you please fix this?

OK.
A document doesn't catch up code.

> BTW, scripts/checkpatch.pl should have told you about some of the
> discrepancies.
> 
> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Yoshinori Sato
<ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html