From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
"chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"kishon@kernel.org" <kishon@kernel.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"nicolas.frattaroli@collabora.com"
<nicolas.frattaroli@collabora.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH v5 11/24] scsi: ufs: mediatek: Rework probe function
Date: Fri, 9 Jan 2026 08:24:25 +0100 [thread overview]
Message-ID: <87887adf-2c94-48c2-8f83-4e772ab50f60@kernel.org> (raw)
In-Reply-To: <dd2eba99adaddf7517f06acf7805d32e261fafa4.camel@mediatek.com>
On 09/01/2026 07:22, Peter Wang (王信友) wrote:
> On Thu, 2026-01-08 at 13:25 +0100, Krzysztof Kozlowski wrote:
>>
>> Please provide here reason, e.g. undocumented ABI. Normally I would
>> ask
>> about ABI impact, but considering this is was just copied from some
>> downstream code I would just not care.
>>
>
> Is it sufficient for us to supplement the ABI document?
> This ABI might affect the ability to reset and recover after
> an UFS error in upstream world.
In normal case yes, but I cannot imagine arguments justifying your usage
of TI properties. Basically it would not pass review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-09 7:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 10:49 [PATCH v5 00/24] MediaTek UFS Cleanup and MT8196 Enablement Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 01/24] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 02/24] dt-bindings: ufs: mediatek,ufs: Complete the binding Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 03/24] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 04/24] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 05/24] phy: mediatek: ufs: Add support for resets Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 06/24] scsi: ufs: mediatek: Rework resets Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 07/24] scsi: ufs: mediatek: Rework 0.9V regulator Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 08/24] scsi: ufs: mediatek: Rework init function Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 09/24] scsi: ufs: mediatek: Rework the crypt-boost stuff Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 10/24] scsi: ufs: mediatek: Handle misc host voltage regulators Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 11/24] scsi: ufs: mediatek: Rework probe function Nicolas Frattaroli
2026-01-08 12:25 ` Krzysztof Kozlowski
2026-01-09 6:22 ` Peter Wang (王信友)
2026-01-09 7:24 ` Krzysztof Kozlowski [this message]
2026-01-09 8:38 ` Peter Wang (王信友)
2026-01-09 8:43 ` Krzysztof Kozlowski
2026-01-09 9:16 ` Peter Wang (王信友)
2026-01-12 15:02 ` AngeloGioacchino Del Regno
2026-01-13 7:26 ` Peter Wang (王信友)
2026-01-20 9:43 ` AngeloGioacchino Del Regno
2026-01-08 10:49 ` [PATCH v5 12/24] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Nicolas Frattaroli
2026-01-08 12:16 ` Krzysztof Kozlowski
2026-01-09 6:21 ` Peter Wang (王信友)
2026-01-08 10:49 ` [PATCH v5 13/24] scsi: ufs: mediatek: Use the common PHY framework Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 14/24] scsi: ufs: mediatek: Switch to newer PM ops helpers Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 15/24] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 16/24] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 17/24] scsi: ufs: mediatek: Add vendor prefix to clk-scale-up-vcore-min Nicolas Frattaroli
2026-01-08 12:22 ` Krzysztof Kozlowski
2026-01-08 10:49 ` [PATCH v5 18/24] scsi: ufs: mediatek: Clean up logging prints Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 19/24] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 20/24] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 21/24] scsi: ufs: mediatek: Rework hardware version reading Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 22/24] scsi: ufs: mediatek: Back up idle timer in per-instance struct Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 23/24] scsi: ufs: mediatek: Remove ret local from link_startup_notify Nicolas Frattaroli
2026-01-08 10:49 ` [PATCH v5 24/24] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87887adf-2c94-48c2-8f83-4e772ab50f60@kernel.org \
--to=krzk@kernel.org \
--cc=Chaotian.Jing@mediatek.com \
--cc=Chunfeng.Yun@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peter.wang@mediatek.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox