From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-244107.protonmail.ch (mail-244107.protonmail.ch [109.224.244.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6058A2EEE9C for ; Wed, 15 Jul 2026 13:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.107 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784123756; cv=none; b=bf81UyL56g+E4LRMv+az5/UJZbiGhjFJqCkaJXoCFKeg0vGZOQdxlkvF3WrKUddBUElb5PFRb12NK5VQM/VyyAoVHpD4C2t4MInKxjjzdWJ6fXx2y3nRfkn8FH/ksxSjVY1c5uAl2pFjNW/A9Dcbx6HCraebyFjb1LYtRgFfN4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784123756; c=relaxed/simple; bh=x1kF+h+M2Ehkve0RXxk9kbNstC2ODtPVH7Imo6k4qaU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=V7TboY2xt2/W+XWC+fyQI5vwxQ51QerY5S9xds05xt2j47mVAuLYapR2vdvultnMCMF55+RmHq0V8YI+VGOJZTte2733rA68Fryg3xiygR6WoFut15W+9OQqlZ6mEIfFUlrVTXVf5+v+BP0II1pWBQtxzenz7sNTIQdmjMyJ/Qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=isRmLWZa; arc=none smtp.client-ip=109.224.244.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="isRmLWZa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail3; t=1784123751; x=1784382951; bh=kqaSUgrmxHJLervNjojPX8XF1IMPj0/QDVmJ+8NJrco=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=isRmLWZaB8DXFHnmWTvQEN4YRkYCFFm90Cb7XxDf1mKyaiqr9cJ+Ebm8DiGYBdda+ Ae+xCRzOJ6biGwLJe2DrNNZqgVwalbs3yzVRfJYVvTuZDj/i1/re+rbNdID8kgQvOi IpmfgOO81CUFwqo6ivil7dsnBv8XQFEuPodDzFYnFTThp6BB9ly6EJ8od0fJ9xTVxs 9pz7f5YKoAUJ6VQren8VBZHickB6lb2aCwM2mss6MGebhgbkOWfc59gRBymwjobN9f tGqGIJo1ih8nuHNiEpVjxSIQ56/YmFIUSF+5RvhaMGCqIoPV3cjfiVwsVIkSwTEtva 6oe5HiaJiviyg== X-Pm-Submission-Id: 4h0d4473fFz2ScX7 From: Esben Haabendal To: "Joshua Crofts" Cc: "Jonathan Cameron" , "David Lechner" , Nuno =?utf-8?Q?S=C3=A1?= , "Andy Shevchenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Nikita Travkin" , "Maslov Dmitry" , , , Subject: Re: [PATCH v2 3/4] iio: light: ltr501: Add ltr329 driver support In-Reply-To: <20260715145324.000005c6@gmail.com> (Joshua Crofts's message of "Wed, 15 Jul 2026 14:53:24 +0200") References: <20260715-liteon-ltr329-v2-0-d18af55edab5@geanix.com> <20260715-liteon-ltr329-v2-3-d18af55edab5@geanix.com> <20260715145324.000005c6@gmail.com> Date: Wed, 15 Jul 2026 15:55:48 +0200 Message-ID: <878q7cmk63.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Joshua Crofts" writes: > On Wed, 15 Jul 2026 14:27:25 +0200 > Esben Haabendal wrote: > >> This adds support for the LTR-329ALS-01 chip, which is similar to >> LTR-303ALS-01, except for interrupt, which LTR-329ALS-01 chip does not >> have. >> >> Signed-off-by: Esben Haabendal >> --- >> drivers/iio/light/ltr501.c | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c >> index 7d045be78c6d..379e57ac5f5b 100644 >> --- a/drivers/iio/light/ltr501.c >> +++ b/drivers/iio/light/ltr501.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include // for ARRAY_SIZE > > Just a small nit, even though the list isn't exactly ordered, please > try to add the new include approximately where it would be if ordered, > i.e. array_size.h goes to the top. Additionally, you don't need to add > a comment. So alphabetically sorted? And even before linux/module.h? Comment is going away... > Everything else seems fine otherwise. /Esben