* [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
@ 2012-09-21 6:32 Wei Yongjun
2012-10-01 23:01 ` Kevin Hilman
2012-10-02 21:36 ` Kevin Hilman
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2012-09-21 6:32 UTC (permalink / raw)
To: tony, linux, grant.likely, rob.herring
Cc: yongjun_wei, linux-omap, linux-arm-kernel, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function omap_device_alloc() returns ERR_PTR()
and never returns NULL pointer. The NULL test in the return value
check should be replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/plat-omap/omap_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
index c490240..3f62de6 100644
--- a/arch/arm/plat-omap/omap_device.c
+++ b/arch/arm/plat-omap/omap_device.c
@@ -671,7 +671,7 @@ struct platform_device __init *omap_device_build_ss(const char *pdev_name, int p
dev_set_name(&pdev->dev, "%s", pdev->name);
od = omap_device_alloc(pdev, ohs, oh_cnt, pm_lats, pm_lats_cnt);
- if (!od)
+ if (IS_ERR(od))
goto odbs_exit1;
ret = platform_device_add_data(pdev, pdata, pdata_len);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
2012-09-21 6:32 [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss() Wei Yongjun
@ 2012-10-01 23:01 ` Kevin Hilman
2012-10-02 21:36 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2012-10-01 23:01 UTC (permalink / raw)
To: Wei Yongjun
Cc: linux, tony, devicetree-discuss, rob.herring, grant.likely,
yongjun_wei, linux-omap, linux-arm-kernel
Wei Yongjun <weiyj.lk@gmail.com> writes:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function omap_device_alloc() returns ERR_PTR()
> and never returns NULL pointer. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Kevin Hilman <khilman@ti.com>
> ---
> arch/arm/plat-omap/omap_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
> index c490240..3f62de6 100644
> --- a/arch/arm/plat-omap/omap_device.c
> +++ b/arch/arm/plat-omap/omap_device.c
> @@ -671,7 +671,7 @@ struct platform_device __init *omap_device_build_ss(const char *pdev_name, int p
> dev_set_name(&pdev->dev, "%s", pdev->name);
>
> od = omap_device_alloc(pdev, ohs, oh_cnt, pm_lats, pm_lats_cnt);
> - if (!od)
> + if (IS_ERR(od))
> goto odbs_exit1;
>
> ret = platform_device_add_data(pdev, pdata, pdata_len);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss()
2012-09-21 6:32 [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss() Wei Yongjun
2012-10-01 23:01 ` Kevin Hilman
@ 2012-10-02 21:36 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2012-10-02 21:36 UTC (permalink / raw)
To: Wei Yongjun
Cc: tony, linux, grant.likely, rob.herring, yongjun_wei, linux-omap,
linux-arm-kernel, devicetree-discuss
Wei Yongjun <weiyj.lk@gmail.com> writes:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function omap_device_alloc() returns ERR_PTR()
> and never returns NULL pointer. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, queueing this for v3.7-rc.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-02 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-21 6:32 [PATCH] ARM: OMAP: omap_device: fix return value check in omap_device_build_ss() Wei Yongjun
2012-10-01 23:01 ` Kevin Hilman
2012-10-02 21:36 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).