From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Om Prakash Singh <quic_omprsing@quicinc.com>,
Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: neil.armstrong@linaro.org, agross@kernel.org,
andersson@kernel.org, conor+dt@kernel.org, davem@davemloft.net,
devicetree@vger.kernel.org, herbert@gondor.apana.org.au,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
marijn.suijten@somainline.org, robh+dt@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH] crypto: qcom-rng: Add hwrng support
Date: Tue, 5 Sep 2023 10:33:45 +0200 [thread overview]
Message-ID: <879d42f0-acf7-441b-a820-3b6f67620eeb@linaro.org> (raw)
In-Reply-To: <76bec0e9-3d80-469b-8666-06f1b639facb@quicinc.com>
On 5.09.2023 04:50, Om Prakash Singh wrote:
>
>
> On 9/1/2023 8:16 PM, Bjorn Andersson wrote:
>> On Fri, Sep 01, 2023 at 06:45:02PM +0530, Om Prakash Singh wrote:
>>> This is follow patch on top of [1]
>>
>> This information does not add value to the git history, if you need to
>> inform the maintainer that the patch should be applied after some
>> in-flight dependency then state so after the "---" line below.
>>
>> But, this patch strictly conflicts with [1], so the statement won't make
>> sense if this is merged.
>>
>>> to add hwrng support for newer platform with trng capability.
>>
>> Please rewrite this so that it's clear that the problem you're trying to
>> solve with this patch (i.e. the problem description) is that newer
>> platforms has trng. Describe how this relates to the existing driver
>> (e.g. same/similar hardware interface). State that you purposefully kept
>> the crypto interface in place for the new hardware as well (so that it's
>> clear that this isn't an accident or oversight).
>>
>>>
>>> [1] https://lore.kernel.org/lkml/20230824-topic-sm8550-rng-v2-4-dfcafbb16a3e@linaro.org/
>>>
>>> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>>> ---
[...]
>>
>> Can you please confirm that it's appropriate to name this "trng" without
>> the "-ee" suffix. Should all trng instances (v2 and v3) skip
>> initialization?
> All trng supported platform needs to skip initialzation.
> we don't need to have both "trng-ee" and "trng".
> If "trng-ee" is prefer we shold update it in patch [1] it itself,
Looking back at ba3ab6371cdd ("crypto: qcom-rng - Add support for prng-ee"),
it was solved in a way that we would stray from today - nowadays
we'd call it qcom,msm8996-prng or something.
The -ee part was only there to discern parts that were initialized
by other software.
Since you said that all TRNGs need that, I'm also for dropping "-ee".
Konrad
next prev parent reply other threads:[~2023-09-05 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:15 [PATCH] crypto: qcom-rng: Add hwrng support Om Prakash Singh
2023-09-01 14:46 ` Bjorn Andersson
2023-09-05 2:50 ` Om Prakash Singh
2023-09-05 8:33 ` Konrad Dybcio [this message]
2023-09-03 17:33 ` Krzysztof Kozlowski
2023-09-05 6:24 ` [PATCH V2] crypto: qcom-rng - Add hw_random interface support Om Prakash Singh
2023-09-05 8:34 ` Konrad Dybcio
2023-09-20 3:04 ` Om Prakash Singh
2023-09-22 15:16 ` Bjorn Andersson
2023-09-25 11:10 ` Om Prakash Singh
2023-09-15 10:19 ` [PATCH] crypto: qcom-rng: Add hwrng support Herbert Xu
2023-09-20 2:56 ` [PATCH V2] crypto: qcom-rng - Add hw_random interface support Om Prakash Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=879d42f0-acf7-441b-a820-3b6f67620eeb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_omprsing@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).