From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Devarsh Thakkar <devarsht@ti.com>,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, eugen.hristev@collabora.com,
ezequiel@vanguardiasur.com.ar, u.kleine-koenig@pengutronix.de,
sakari.ailus@linux.intel.com, praneeth@ti.com, nm@ti.com,
vigneshr@ti.com, a-bhatia1@ti.com, j-luthra@ti.com,
b-brnich@ti.com, detheridge@ti.com, p-mantena@ti.com,
vijayp@ti.com
Subject: Re: [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver
Date: Sun, 20 Aug 2023 22:25:37 +0200 [thread overview]
Message-ID: <879f8bf7-db08-0add-9bff-a56ae07ffc67@linaro.org> (raw)
In-Reply-To: <530306bc-174e-c75d-40c5-6fa42d69af31@ti.com>
On 20/08/2023 18:46, Devarsh Thakkar wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - items:
>>> + - const: ti,e5010-jpeg-enc
>>
>> TI did not make e5010. Use SoC-based compatible.
>>
>>> + - const: img,e5010-jpeg-enc
>>> + - const: img,e5010-jpeg-enc
>>
>> img,e5010-jpeg-enc cannot be compatible with img,e5010-jpeg-enc. It does
>> not make sense. I guess I did not expect you are going to use what you
>> wrote in v1 directly... I thought it is just about syntax.
>>
>
> Sorry but I did not understand this fully, the possible compatibles are:
>
> 1) "ti,am62a-jpeg-enc", "img,e5010-jpeg-enc"
> or
> 2) "img,e5010-jpeg-enc"
>
> anything else will not comply during dtbs_check as shown below :
Ah, you are right, ENOTENOUGHCOFFEE or some other issue on my side.
>
> For e.g. If I use below compatible :
> "img,e5010-jpeg-enc", "img,e5010-jpeg-enc"
>
> and run dtbs_check, it throw below error :
>
> make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml
> ti/k3-am62a7-sk.dtb
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
> /home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb:
> jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must
> be fixed:
> ['img,e5010-jpeg-enc', 'img,e5010-jpeg-enc'] is too long
> 'ti,am62a-jpeg-enc' was expected
> From schema:
> /home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>
>
> Similarly, if I use below compatible :
>
> "ti,am62a-jpeg-enc",
> It throw below error :
>
> make CHECK_DTBS=y DT_SCHEMA_FILES=media/img,e5010-jpeg-enc.yaml
> ti/k3-am62a7-sk.dtb
> DTC_CHK arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb
> /home/devarsht/ti/linux-next2/linux-next/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb:
> jpeg-encoder@fd20000: compatible: 'oneOf' conditional failed, one must
> be fixed:
> ['ti,am62a-jpeg-enc'] is too short
> 'img,e5010-jpeg-enc' was expected
> From schema:
> /home/devarsht/ti/linux-next2/linux-next/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
>
>
> But If I use either 1) or 2) it does not throw any error.
> Please let me know if I missed to understand your point.
Yes, you are right, sorry for that.
However it still should be "ti,am62a-jpeg-enc", not ti,e5010...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-20 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:22 [PATCH v3 0/4] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2023-08-16 15:22 ` [PATCH v3 1/4] dt-bindings: media: Add bindings for Imagination E5010 JPEG Encoder driver Devarsh Thakkar
2023-08-19 14:00 ` Krzysztof Kozlowski
2023-08-20 16:46 ` Devarsh Thakkar
2023-08-20 20:25 ` Krzysztof Kozlowski [this message]
2023-08-16 15:22 ` [PATCH v3 2/4] media: imagination: Add " Devarsh Thakkar
2023-08-22 10:27 ` Andrzej Pietrasiewicz
2023-08-31 13:24 ` Devarsh Thakkar
2023-09-06 12:38 ` Hans Verkuil
2023-08-16 15:22 ` [DONOTMERGE PATCH v3 3/4] arm64: dts: ti: k3-am62a : Add E5010 JPEG Encoder Devarsh Thakkar
2023-08-16 15:22 ` [DONOTMERGE PATCH v3 4/4] arm64: defconfig: Enable " Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=879f8bf7-db08-0add-9bff-a56ae07ffc67@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-bhatia1@ti.com \
--cc=b-brnich@ti.com \
--cc=conor+dt@kernel.org \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).