From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "xianwei.zhao" <xianwei.zhao@amlogic.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
devicetree@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [RFC PATCH 2/2] arm64: dts: add support for C3 based Amlogic AW409
Date: Mon, 1 May 2023 12:00:33 +0200 [thread overview]
Message-ID: <87a3bb36-bb75-5c01-dbdc-ee91d6496321@linaro.org> (raw)
In-Reply-To: <5a11ccfd-eafa-391a-e2b9-d032510c9e7b@amlogic.com>
On 27/04/2023 10:54, xianwei.zhao wrote:
> Hi Krzysztof,
>
> Thank you for your reply.
>
> On 2023/4/19 15:48, Krzysztof Kozlowski wrote:
>> [你通常不会收到来自krzysztof.kozlowski@linaro.org 的电子邮件。请访问https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>>
>> [ EXTERNAL EMAIL ]
>>
>> On 19/04/2023 09:38, =Xianwei Zhao wrote:
>>> From: Xianwei Zhao<xianwei.zhao@amlogic.com>
>>>
>>> Amlogic C3 is an advanced edge AI processor designed for smart IP camera
>>> applications.
>>>
>>> Add basic support for the C3 based Amlogic AW409 board, which describes
>>> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>>> booting up into the serial console.
>>>
>>> Signed-off-by: Xianwei Zhao<xianwei.zhao@amlogic.com>
>>> ---
>>> arch/arm64/boot/dts/amlogic/Makefile | 1 +
>>> .../amlogic/amlogic-c3-c302x-aw409-256m.dts | 30 +++++++
>>> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 87 +++++++++++++++++++
>>> 3 files changed, 118 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>>> index cd1c5b04890a..d2b5d0d750bc 100644
>>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>>> @@ -74,3 +74,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb
>>> +dtb-$(CONFIG_ARCH_AMLIPC) += amlogic-c3-c302x-aw409-256m.dtb
>>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>> new file mode 100644
>>> index 000000000000..38ca98a32181
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>> @@ -0,0 +1,30 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "amlogic-c3.dtsi"
>>> +
>>> +/ {
>>> + model = "Amlogic C302 aw409 Development Board";
>>> + compatible = "amlogic,aw409", "amlogic,c3";
>> Undocumented compatibles. Run checkpatch and fix all warnings. Anyway, I
>> am not sure this warrants separate architecture. Isn't C3 standard Meson
>> SoC?
> The patch related to bindings is committed, see:
> https://lore.kernel.org/all/20230407102704.1055152-1-kelvin.zhang@amlogic.com/
And how can we know this? There are no bindings in next, so you are
supposed to sent these together. At minimum link to the bindings patch.
Otherwise you will keep getting review comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-01 10:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 7:38 [RFC PATCH 0/2] Baisc devicetree support for Amlogic C3 =Xianwei Zhao
2023-04-19 7:38 ` [RFC PATCH 1/2] arm64: amlogic: add new ARCH_AMLIPC for IPC SoC =Xianwei Zhao
2023-04-19 7:45 ` Krzysztof Kozlowski
2023-04-19 10:22 ` Neil Armstrong
2023-04-19 13:14 ` Dmitry Rokosov
2023-04-19 13:43 ` Neil Armstrong
2023-04-19 16:04 ` Dmitry Rokosov
2023-04-19 16:25 ` Neil Armstrong
2023-04-19 17:00 ` Dmitry Rokosov
2023-04-20 8:43 ` Kelvin Zhang
2023-04-20 12:18 ` Neil Armstrong
2023-04-27 9:20 ` Kelvin Zhang
2023-04-20 12:39 ` Krzysztof Kozlowski
2023-04-27 9:23 ` Kelvin Zhang
2023-04-19 7:38 ` [RFC PATCH 2/2] arm64: dts: add support for C3 based Amlogic AW409 =Xianwei Zhao
2023-04-19 7:48 ` Krzysztof Kozlowski
2023-04-27 9:25 ` xianwei.zhao
[not found] ` <5a11ccfd-eafa-391a-e2b9-d032510c9e7b@amlogic.com>
2023-05-01 10:00 ` Krzysztof Kozlowski [this message]
2023-04-19 10:23 ` Neil Armstrong
2023-04-19 13:09 ` [RFC PATCH 0/2] Baisc devicetree support for Amlogic C3 Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a3bb36-bb75-5c01-dbdc-ee91d6496321@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).